[llvm] [DXIL] Implement pow lowering (PR #86733)

Farzon Lotfi via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 26 14:16:24 PDT 2024


================
@@ -197,6 +198,26 @@ static bool expandLog10Intrinsic(CallInst *Orig) {
   return expandLogIntrinsic(Orig, numbers::ln2f / numbers::ln10f);
 }
 
+static bool expandPowIntrinsic(CallInst *Orig) {
----------------
farzonl wrote:

It really should be a return as that will break the flow of execution and end the function.  ending the function execution as soon as possible is a defensive coding strategy we should pursue.  I also don't find break anymore aesthetically pleasing than `return true;` both would be adding a second line per case statement.

https://github.com/llvm/llvm-project/pull/86733


More information about the llvm-commits mailing list