[llvm] [PassManager] Support MachineFunctionProperties (PR #83668)

Arthur Eubanks via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 26 09:19:45 PDT 2024


https://github.com/aeubanks approved this pull request.

this seems ok, I don't think we'll get anything much better

sorry for the very long back and forth. I think with Chandler's vision of using concepts (basically Rust dyn traits) to model passes (as opposed to inheritance), all the C++ templates goo makes this hard to do in a nice way

this will miss cases where we directly invoke a pass without going through the MachinePass concept/model, but that should be pretty rare (impossible right now?)

just one comment

https://github.com/llvm/llvm-project/pull/83668


More information about the llvm-commits mailing list