[llvm] [TBAA] Tests for invalid tbaa.struct metadata (PR #86167)

[Julian Nagele via llvm-commits]

https://github.com/juliannagele updated https://github.com/llvm/llvm-project/pull/86167

>From 1b356faba1742acee7738e0c63987a2c26580f19 Mon Sep 17 00:00:00 2001
From: Julian Nagele <j.nagele at apple.com>
Date: Thu, 21 Mar 2024 12:06:35 +0000
Subject: [PATCH 1/2] Add tests for invalid tbaa.struct metadata

---
 llvm/test/Verifier/tbaa-struct.ll | 38 +++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 llvm/test/Verifier/tbaa-struct.ll

diff --git a/llvm/test/Verifier/tbaa-struct.ll b/llvm/test/Verifier/tbaa-struct.ll
new file mode 100644
index 00000000000000..c995fc97addebb
--- /dev/null
+++ b/llvm/test/Verifier/tbaa-struct.ll
@@ -0,0 +1,38 @@
+; RUN: llvm-as < %s 2>&1
+
+define void @test_overlapping_regions(ptr %a1) {
+  %ld = load i8, ptr %a1, align 1, !tbaa.struct !0
+  ret void
+}
+
+define void @test_size_not_integer(ptr %a1) {
+  store i8 1, ptr %a1, align 1, !tbaa.struct !5
+  ret void
+}
+
+define void @test_offset_not_integer(ptr %a1, ptr %a2) {
+  tail call void @llvm.memcpy.p0.p0.i64(ptr align 8 %a1, ptr align 8 %a2, i64 16, i1 false), !tbaa.struct !6
+  ret void
+}
+
+define void @test_tbaa_missing(ptr %a1, ptr %a2) {
+  tail call void @llvm.memcpy.p0.p0.i64(ptr align 8 %a1, ptr align 8 %a2, i64 16, i1 false), !tbaa.struct !7
+  ret void
+}
+
+define void @test_tbaa_invalid(ptr %a1) {
+  store i8 1, ptr %a1, align 1, !tbaa.struct !8
+  ret void
+}
+
+declare void @llvm.memcpy.p0.p0.i64(ptr nocapture, ptr nocapture, i64, i1) nounwind
+
+!0 = !{i64 0, i64 4, !1, i64 1, i64 4, !1}
+!1 = !{!2, !2, i64 0}
+!2 = !{!"int", !3, i64 0}
+!3 = !{!"omnipotent char", !4, i64 0}
+!4 = !{!"Simple C++ TBAA"}
+!5 = !{i64 0, !2, !1}
+!6 = !{!2, i64 0, !1}
+!7 = !{i64 0, i64 4, null}
+!8 = !{i64 0, i64 4, !2}

>From 62b6c6c202acdae63b7f9b330efd0734873a19d0 Mon Sep 17 00:00:00 2001
From: Julian Nagele <j.nagele at apple.com>
Date: Tue, 26 Mar 2024 11:39:04 +0000
Subject: [PATCH 2/2] fixup! Add tests for invalid tbaa.struct metadata

---
 llvm/test/Verifier/tbaa-struct.ll | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/llvm/test/Verifier/tbaa-struct.ll b/llvm/test/Verifier/tbaa-struct.ll
index c995fc97addebb..b8ddc7cee496a9 100644
--- a/llvm/test/Verifier/tbaa-struct.ll
+++ b/llvm/test/Verifier/tbaa-struct.ll
@@ -1,5 +1,7 @@
 ; RUN: llvm-as < %s 2>&1
 
+; FIXME: The verifer should reject the invalid !tbaa.struct nodes below.
+
 define void @test_overlapping_regions(ptr %a1) {
   %ld = load i8, ptr %a1, align 1, !tbaa.struct !0
   ret void