[lld] [lld][COFF] Fix: Merge `.drectve` sections in ObjFile::readSections (PR #86380)

Rickey Bowers Jr. via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 25 13:55:54 PDT 2024


================

----------------
bitRAKE wrote:

> I didn't check your implementation here, but it needs to be able to handle strings separated by null bytes, e.g. as emitted by `.asciz` in [503bc5f](https://github.com/llvm/llvm-project/commit/503bc5f66111f7e4fc79972bb9bfec8bb5606bab).

The implementation processes the section in place - no assumption about padding, nor merging of sections. If the section would process prior than it would process still.

Thanks for the additional perspective.

https://github.com/llvm/llvm-project/pull/86380


More information about the llvm-commits mailing list