[llvm] [bazel] Fix minor buildifier warnings (NFC) (PR #86566)

Keith Smiley via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 25 12:39:06 PDT 2024


https://github.com/keith created https://github.com/llvm/llvm-project/pull/86566

None

>From e596d7699a532d0e4fb734655759f31608347f3a Mon Sep 17 00:00:00 2001
From: Keith Smiley <keithbsmiley at gmail.com>
Date: Mon, 25 Mar 2024 12:38:02 -0700
Subject: [PATCH] [bazel] Fix minor buildifier warnings (NFC)

---
 utils/bazel/llvm-project-overlay/llvm/BUILD.bazel        | 9 +++++----
 .../llvm-project-overlay/llvm/unittests/BUILD.bazel      | 5 +++--
 utils/bazel/llvm-project-overlay/mlir/BUILD.bazel        | 2 +-
 3 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel b/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
index 65173f986585c4..26fc1041cf2ef3 100644
--- a/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
@@ -623,7 +623,7 @@ cc_library(
     srcs = [
         "utils/TableGen/Common/GlobalISel/CodeExpander.cpp",
     ],
-    hdrs = glob([
+    hdrs = [
         # We have to include these headers here as well as in the `hdrs` below
         # to allow the `.cpp` files to use file-relative-inclusion to find
         # them, even though consumers of this library use inclusion relative to
@@ -631,7 +631,7 @@ cc_library(
         # This mixture appears to be incompatible with header modules.
         "utils/TableGen/Common/GlobalISel/CodeExpander.h",
         "utils/TableGen/Common/GlobalISel/CodeExpansions.h",
-    ]),
+    ],
     copts = llvm_copts,
     features = ["-header_modules"],
     strip_include_prefix = "utils/TableGen",
@@ -665,10 +665,11 @@ cc_binary(
             # listed here. MC uses headers produced by tablegen, so it cannot be a
             # regular dependency.
             "include/llvm/MC/*.h",
-            "include/llvm/TargetParser/SubtargetFeature.h",
         ],
         exclude = ["utils/TableGen/Common/GlobalISel/CodeExpander.cpp"],
-    ),
+    ) + [
+        "include/llvm/TargetParser/SubtargetFeature.h",
+    ],
     copts = llvm_copts,
     includes = ["utils/TableGen"],
     stamp = 0,
diff --git a/utils/bazel/llvm-project-overlay/llvm/unittests/BUILD.bazel b/utils/bazel/llvm-project-overlay/llvm/unittests/BUILD.bazel
index c8863af43c400d..dd42f84d16dc4b 100644
--- a/utils/bazel/llvm-project-overlay/llvm/unittests/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/llvm/unittests/BUILD.bazel
@@ -357,10 +357,11 @@ cc_test(
         [
             "IR/*.cpp",
             "IR/*.h",
-            "Support/KnownBitsTest.h",
         ],
         allow_empty = False,
-    ),
+    ) + [
+        "Support/KnownBitsTest.h",
+    ],
     shard_count = 20,
     deps = [
         "//llvm:Analysis",
diff --git a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
index 88b46bdb326ca3..71fb97bff62fb7 100644
--- a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
@@ -8197,8 +8197,8 @@ cc_library(
     deps = [
         ":ConversionPassIncGen",
         ":EmitCDialect",
-        ":MemRefDialect",
         ":IR",
+        ":MemRefDialect",
         ":Pass",
         ":Support",
         ":TransformUtils",



More information about the llvm-commits mailing list