[compiler-rt] [compiler-rt] Also consider SIGPROF as a synchronous signal (PR #85188)

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 25 12:22:23 PDT 2024


MaskRay wrote:

> > I am sorry for your experience. @vitalybuka do you know if there are any docs on how to find appropriate reviewers for PRs? OR what's the process? In [syzkaller we use](https://github.com/google/syzkaller/blob/master/.github/CODEOWNERS?rgh-link-date=2024-03-25T18%3A44%3A12Z) [CODEOWNERS](https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners) thing to auto-assign people to PRs based on path wildcards.
> 
> Probably "first time commiters" can't pick reviewers anyway.
> 
> I guess we suppose to see some notifications, I remember @MaskRay set ed up something. I assumes it will auto-assign at some point?
> 
> This patch is in [github.com/orgs/llvm/teams/pr-subscribers-compiler-rt-sanitizer](https://github.com/orgs/llvm/teams/pr-subscribers-compiler-rt-sanitizer) and I guess at least ~12 people have it in mailbox, but didn't act on that yet.

https://llvm.org/docs/Contributing.html#how-to-submit-a-patch provides some information about reviewer selection.
If a user cannot add reviewers, `@user0 @user1` is a good alternative.

llvm-project notifications are of huge volume and I think nobody can keep track of everything... I personally use quite a few filters and often miss "Team mention" ones (lot of times "Mention" as well; a lot of work is volunteer work).

```
Apply label "Mention": from:(notifications at github.com) to:(mention at noreply.github.com)
Apply label "Team mention": from:(notifications at github.com) to:(team_mention at noreply.github.com)
```

https://github.com/llvm/llvm-project/pull/85188


More information about the llvm-commits mailing list