[lld] [llvm] WIP: [LLD][COFF] Make unresolved symbol search behavior compliant with MSVC link.exe (PR #85290)

via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 25 11:18:19 PDT 2024


================
@@ -91,13 +92,20 @@ class LinkerDriver {
 
   // Used by ArchiveFile to enqueue members.
   void enqueueArchiveMember(const Archive::Child &c, const Archive::Symbol &sym,
-                            StringRef parentName);
+                            StringRef parentName,
+                            ArchiveFile *parent = nullptr);
 
-  void enqueuePDB(StringRef Path) { enqueuePath(Path, false, false); }
+  void enqueuePDB(StringRef Path) {
+    enqueuePath(Path, false, false, /*parent=*/std::nullopt);
----------------
sylvain-audi wrote:

`parent` argument already has `std::nullopt` as default param. I would either revert this line, or remove the default value

https://github.com/llvm/llvm-project/pull/85290


More information about the llvm-commits mailing list