[llvm] [RISCV][GlobalISel] Legalize Scalable Vector Loads (PR #84965)

Michael Maitland via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 25 09:36:44 PDT 2024


================
@@ -220,7 +220,8 @@ struct TypePairAndMemDesc {
            Align >= Other.Align &&
            // FIXME: This perhaps should be stricter, but the current legality
            // rules are written only considering the size.
-           MemTy.getSizeInBits() == Other.MemTy.getSizeInBits();
----------------
michaelmaitland wrote:

Did this really cause a problem? It looks like `TypeSize::operator==` should not cause a crash for scalable vectors:

```
constexpr bool operator==(const FixedOrScalableQuantity &RHS) const {
  return Quantity == RHS.Quantity && Scalable == RHS.Scalable;
}
```

https://github.com/llvm/llvm-project/pull/84965


More information about the llvm-commits mailing list