[llvm] Upstreaming warning suppression to LLVM (PR #83590)
Krzysztof Drewniak via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 25 08:27:18 PDT 2024
krzysz00 wrote:
@ivarusic-amd Per our previous discussion on this
1. LLVM, and CMake in general, have utilities for this sort of thing that are better-behaved than directly hacking on `CMAKE_CXX_FLAGS` and you should be using those.
2. This needs a much more informative commit message
3. Per the notes above, instead of making this a project wide "add a #define", we might want to target this more specifically onto the parts of the MLIR folder that use those types. Then again, since the code in question is part of `BuiltinAttributes.td`, a MLIR-wide `-D` flag might be the right call here.
https://github.com/llvm/llvm-project/pull/83590
More information about the llvm-commits
mailing list