[llvm] 46a737c - [LLVM] Fix linking object library in tablegen
Joseph Huber via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 25 06:04:06 PDT 2024
Author: Joseph Huber
Date: 2024-03-25T08:02:53-05:00
New Revision: 46a737cef2a709d5c121ab616fc80088ce2eed46
URL: https://github.com/llvm/llvm-project/commit/46a737cef2a709d5c121ab616fc80088ce2eed46
DIFF: https://github.com/llvm/llvm-project/commit/46a737cef2a709d5c121ab616fc80088ce2eed46.diff
LOG: [LLVM] Fix linking object library in tablegen
Summary:
The patch https://github.com/llvm/llvm-project/pull/80847 introduced
some changes to how we build tablegen. Some files weren't build included
properly on my build. We don't need to fish out the objects directly
from an object library build, we can simply add it to the link libraries
and CMake will include them for you. This fixed the issue of missings
defs for me and is more canonical.
Added:
Modified:
llvm/utils/TableGen/Common/CMakeLists.txt
Removed:
################################################################################
diff --git a/llvm/utils/TableGen/Common/CMakeLists.txt b/llvm/utils/TableGen/Common/CMakeLists.txt
index 0e985a08324776..0440f027f28659 100644
--- a/llvm/utils/TableGen/Common/CMakeLists.txt
+++ b/llvm/utils/TableGen/Common/CMakeLists.txt
@@ -33,7 +33,9 @@ add_llvm_library(LLVMTableGenCommon STATIC OBJECT EXCLUDE_FROM_ALL
SubtargetFeatureInfo.cpp
Types.cpp
VarLenCodeEmitterGen.cpp
- $<TARGET_OBJECTS:obj.LLVMTableGenBasic>
+
+ LINK_LIBS
+ LLVMTableGenBasic
DEPENDS
vt_gen
More information about the llvm-commits
mailing list