[llvm] 7434a6b - [TableGen] Fix Linker Errors

[via llvm-commits]

Author: pvanhout
Date: 2024-03-25T10:50:08+01:00
New Revision: 7434a6b96c68b6835a6de6e98199dcfc35981dd5

URL: https://github.com/llvm/llvm-project/commit/7434a6b96c68b6835a6de6e98199dcfc35981dd5
DIFF: https://github.com/llvm/llvm-project/commit/7434a6b96c68b6835a6de6e98199dcfc35981dd5.diff

LOG: [TableGen] Fix Linker Errors

Fix linker errors after landing fa3d789df15bd1f58fb8ba4ea3be909218cf7f03

Added: 
    

Modified: 
    llvm/utils/TableGen/Basic/CMakeLists.txt
    llvm/utils/TableGen/CMakeLists.txt
    llvm/utils/TableGen/Common/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/llvm/utils/TableGen/Basic/CMakeLists.txt b/llvm/utils/TableGen/Basic/CMakeLists.txt
index f2927d05c175c3..5a899e3b7c8035 100644
--- a/llvm/utils/TableGen/Basic/CMakeLists.txt
+++ b/llvm/utils/TableGen/Basic/CMakeLists.txt
@@ -8,7 +8,7 @@ set(LLVM_LINK_COMPONENTS
   TableGen
   )
 
-add_llvm_library(LLVMTableGenBasic STATIC OBJECT EXCLUDE_FROM_ALL
+add_llvm_library(LLVMTableGenBasic OBJECT EXCLUDE_FROM_ALL
   CodeGenIntrinsics.cpp
   SDNodeProperties.cpp
 )

diff  --git a/llvm/utils/TableGen/CMakeLists.txt b/llvm/utils/TableGen/CMakeLists.txt
index 14690329cabf70..577aeded4be72c 100644
--- a/llvm/utils/TableGen/CMakeLists.txt
+++ b/llvm/utils/TableGen/CMakeLists.txt
@@ -75,10 +75,10 @@ add_tablegen(llvm-tblgen LLVM
   X86MnemonicTables.cpp
   X86ModRMFilters.cpp
   X86RecognizableInstr.cpp
+  $<TARGET_OBJECTS:obj.LLVMTableGenBasic>
   $<TARGET_OBJECTS:obj.LLVMTableGenCommon>
 
   DEPENDS
   intrinsics_gen # via llvm-min-tablegen
   )
-target_link_libraries(llvm-tblgen PRIVATE LLVMTableGenCommon)
 set_target_properties(llvm-tblgen PROPERTIES FOLDER "Tablegenning")

diff  --git a/llvm/utils/TableGen/Common/CMakeLists.txt b/llvm/utils/TableGen/Common/CMakeLists.txt
index 491d9bd2949dce..0e985a08324776 100644
--- a/llvm/utils/TableGen/Common/CMakeLists.txt
+++ b/llvm/utils/TableGen/Common/CMakeLists.txt
@@ -39,7 +39,6 @@ add_llvm_library(LLVMTableGenCommon STATIC OBJECT EXCLUDE_FROM_ALL
   vt_gen
   )
 set_target_properties(LLVMTableGenCommon PROPERTIES FOLDER "Tablegenning")
-target_link_libraries(LLVMTableGenCommon PUBLIC LLVMTableGenBasic)
 
 # Users may include its headers as "Common/*.h"
 target_include_directories(LLVMTableGenCommon