[llvm] [dsymutil][DWARFLinker] Refactor handling mergeable libraries. (PR #80615)
Alexey Lapshin via llvm-commits
llvm-commits at lists.llvm.org
Sun Mar 24 09:53:05 PDT 2024
avl-llvm wrote:
> I did not see this PR, sorry for the delayed response. Generally looks good! I verified that the attached [relink.tar.gz](https://github.com/llvm/llvm-project/files/14674300/relink.tar.gz) produces a debuggable executable. (`make mrproper && make all-relink && make strip && lldb`)
>
> A few minor outstanding things:
>
> * The tests need to be updated to reflect the changes, to at the very list stop referencing relocation maps.
>
> * Similarly to [[dsymutil] Fix spurious warnings in MachODebugMapParser #78794](https://github.com/llvm/llvm-project/pull/78794), could you please further update `switchToNewLibDebugMapObject` so that `addCommonSymbols/resetParserState` is at the beginning of the function and that duplicate N_LIB entry names are tracked? To void time spent handling errors and emitting warnings.
>
>
> Otherwise, the rest is fine by me 👍
Thank you for the comments! I updated patch for `switchToNewLibDebugMapObject`(moved `addCommonSymbols/resetParserState` and check for duplicate N_LIB entry names).
I did not understand what should be done for the tests. Could you point for the relocation map reference which should be deleted, please?
https://github.com/llvm/llvm-project/pull/80615
More information about the llvm-commits
mailing list