[compiler-rt] 0ba678a - [tsan] Set `thr->is_inited` after SlotAttachAndLock (#86342)

via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 22 15:12:12 PDT 2024


Author: Vitaly Buka
Date: 2024-03-22T15:12:09-07:00
New Revision: 0ba678a53d3ef7d125f38720a59875035739dc9b

URL: https://github.com/llvm/llvm-project/commit/0ba678a53d3ef7d125f38720a59875035739dc9b
DIFF: https://github.com/llvm/llvm-project/commit/0ba678a53d3ef7d125f38720a59875035739dc9b.diff

LOG: [tsan] Set `thr->is_inited` after SlotAttachAndLock (#86342)

Almost NFC.

This is symmetrical to `ThreadFinish`, which
resets the slot after `is_inited`.

Added: 
    

Modified: 
    compiler-rt/lib/tsan/rtl/tsan_rtl_thread.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/tsan/rtl/tsan_rtl_thread.cpp b/compiler-rt/lib/tsan/rtl/tsan_rtl_thread.cpp
index 06c34a2e438388..5316a7862e449c 100644
--- a/compiler-rt/lib/tsan/rtl/tsan_rtl_thread.cpp
+++ b/compiler-rt/lib/tsan/rtl/tsan_rtl_thread.cpp
@@ -160,6 +160,10 @@ void ThreadStart(ThreadState *thr, Tid tid, tid_t os_id,
   }
   Free(thr->tctx->sync);
 
+#if !SANITIZER_GO
+  thr->is_inited = true;
+#endif
+
   uptr stk_addr = 0;
   uptr stk_size = 0;
   uptr tls_addr = 0;
@@ -205,9 +209,6 @@ void ThreadContext::OnStarted(void *arg) {
   if (common_flags()->detect_deadlocks)
     thr->dd_lt = ctx->dd->CreateLogicalThread(tid);
   thr->tctx = this;
-#if !SANITIZER_GO
-  thr->is_inited = true;
-#endif
 }
 
 void ThreadFinish(ThreadState *thr) {


        


More information about the llvm-commits mailing list