[llvm] [z/OS][GOFF] Implement support for writing ESD + TXT records by the GOFFObjectWriter (PR #85851)

Ulrich Weigand via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 22 06:51:32 PDT 2024


================
@@ -217,34 +222,403 @@ void GOFFOstream::write_impl(const char *Ptr, size_t Size) {
   }
 }
 
+/// \brief Wrapper class for symbols used exclusively for the symbol table in a
+/// GOFF file.
+class GOFFSymbol {
+public:
----------------
uweigand wrote:

I don't like that all these fields are just "public" and code goes modifying them all over the place.  It would really be preferable to provide a number of constructors for the different symbol types - this would ensure that for each type, all the mandatory information for this type is actually provided.

https://github.com/llvm/llvm-project/pull/85851


More information about the llvm-commits mailing list