[llvm] [DWARF5][COFF] Fix wrong relocation in .debug_line (PR #83773)

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 21 07:27:10 PDT 2024


mstorsjo wrote:

> > @timoh-ba Btw, before merging: Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-emails-on-github-should-we-do-something-about-it) for more information.
> 
> Okay, I turned it off, I hope it worked?

Yes, seems so. Thanks!

> Also I noticed that I linked this PR using its github link, from the git log of llvm I see that some people do it that way, some tag it using the number and a #. Should I change it or is this not important?

If the PR is merged via the web UI, the PR number gets added automatically at the end of the subject line (although I can edit it before it gets finalized). If some people merge their PRs by pushing their commits manually, they might link to the PR review discussion manually by mentioning it in the commit message.

But our PRs are merged via "squash and merge", and we have it configured to default the commit message to the PR subject + initial comment. So if updating the commit message, it's good to update the PR subject and description as well, so it gets right in the end.

In this case, I guess the message from the commit is the most up to date and correct one? I can copypaste it from there when merging it, and I can leave out redundant manual reference to the PR.

https://github.com/llvm/llvm-project/pull/83773


More information about the llvm-commits mailing list