[llvm] [ValueTracking] [ValueTracking] Add more conditions in `isTruePredicate` (PR #86083)

[Nikita Popov via llvm-commits]

nikic wrote:

@goldsteinn I think the patch you have in mind is https://github.com/llvm/llvm-project/pull/69471. Totally forgot about that one...

My general feedback on this patch is that we're re-implementing simplifyICmpInst() here. I think it would be good to at least check what the compile-time impact of using simplifyICmpInst() instead would be -- I suspect "bad", but best to confirm that...

Otherwise, I am fine with having some pragmatic duplication here, if having it is useful. I just want to make sure we don't end up with a full reimplementation down the line because a certain someone keeps spotting missing cases :)

https://github.com/llvm/llvm-project/pull/86083