[llvm] [mlir][nvgpu][nvvm] Add myself as a primary reviewer for nvgpu and nvvm dialects (PR #85414)
Guray Ozen via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 20 03:55:24 PDT 2024
https://github.com/grypp updated https://github.com/llvm/llvm-project/pull/85414
>From 35f3edadb9cc65425cca8bf2531cd19da1eede7a Mon Sep 17 00:00:00 2001
From: Guray Ozen <guray.ozen at gmail.com>
Date: Tue, 9 Jan 2024 18:09:12 +0100
Subject: [PATCH 1/5] Update CODEOWNERS
Add myself as a default reviewer for NVGPU and NVVM dialects
---
.github/CODEOWNERS | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index 6bf2b2ae034f1e..8c2cecb9e66e7c 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -106,5 +106,14 @@ clang/test/AST/Interp/ @tbaederr
# MLIR Sparsifier.
/mlir/**/*SparseTensor*/ @aartbik @PeimingLiu @yinying-lisa-li @matthias-springer
+# MLIR NVGPU Dialect
+/mlir/**/NVGPU/ @grypp
+/mlir/**/NVGPUTo*/ @grypp
+
+# MLIR NVVM Dialect in MLIR
+/mlir/**/LLVMIR/BasicPtxBuilderInterface* @grypp
+/mlir/**/LLVMIR/NVVM* @grypp
+/mlir/**/NVVMToLLVM*/ @grypp
+
# BOLT
/bolt/ @aaupov @maksfb @rafaelauler @ayermolo @dcci
>From f7c8417c36c0b038d9bbc4a3dd7225305169cf25 Mon Sep 17 00:00:00 2001
From: grypp <guray.ozen at gmail.com>
Date: Fri, 15 Mar 2024 15:16:29 +0000
Subject: [PATCH 2/5] add test folder
---
.github/CODEOWNERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index 8c2cecb9e66e7c..e7d5b97098cdeb 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -109,6 +109,8 @@ clang/test/AST/Interp/ @tbaederr
# MLIR NVGPU Dialect
/mlir/**/NVGPU/ @grypp
/mlir/**/NVGPUTo*/ @grypp
+/mlir/**/NVGPUTo*/ @grypp
+/mlir/**/sm90*/ @grypp
# MLIR NVVM Dialect in MLIR
/mlir/**/LLVMIR/BasicPtxBuilderInterface* @grypp
>From b60502f1a12da72211ca9179387fe65b5938c717 Mon Sep 17 00:00:00 2001
From: grypp <guray.ozen at gmail.com>
Date: Wed, 20 Mar 2024 10:12:52 +0000
Subject: [PATCH 3/5] address comments
---
.github/CODEOWNERS | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index e7d5b97098cdeb..43580faeae076a 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -108,14 +108,11 @@ clang/test/AST/Interp/ @tbaederr
# MLIR NVGPU Dialect
/mlir/**/NVGPU/ @grypp
-/mlir/**/NVGPUTo*/ @grypp
-/mlir/**/NVGPUTo*/ @grypp
-/mlir/**/sm90*/ @grypp
+/mlir/test/**/CUDA/ @grypp
# MLIR NVVM Dialect in MLIR
/mlir/**/LLVMIR/BasicPtxBuilderInterface* @grypp
-/mlir/**/LLVMIR/NVVM* @grypp
-/mlir/**/NVVMToLLVM*/ @grypp
+/mlir/**/NVVM*/
# BOLT
/bolt/ @aaupov @maksfb @rafaelauler @ayermolo @dcci
>From 627b7decdbd4cb76d268f7ba52f73b262265a50e Mon Sep 17 00:00:00 2001
From: grypp <guray.ozen at gmail.com>
Date: Wed, 20 Mar 2024 10:53:31 +0000
Subject: [PATCH 4/5] add *
---
.github/CODEOWNERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index 43580faeae076a..7751142f854155 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -107,7 +107,7 @@ clang/test/AST/Interp/ @tbaederr
/mlir/**/*SparseTensor*/ @aartbik @PeimingLiu @yinying-lisa-li @matthias-springer
# MLIR NVGPU Dialect
-/mlir/**/NVGPU/ @grypp
+/mlir/**/NVGPU*/ @grypp
/mlir/test/**/CUDA/ @grypp
# MLIR NVVM Dialect in MLIR
>From d3ff7ceb69638140012f352771c1c0a91f7c62c5 Mon Sep 17 00:00:00 2001
From: grypp <guray.ozen at gmail.com>
Date: Wed, 20 Mar 2024 10:55:11 +0000
Subject: [PATCH 5/5] fix
---
.github/CODEOWNERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index 7751142f854155..fb1ef0e8143f52 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -111,8 +111,8 @@ clang/test/AST/Interp/ @tbaederr
/mlir/test/**/CUDA/ @grypp
# MLIR NVVM Dialect in MLIR
-/mlir/**/LLVMIR/BasicPtxBuilderInterface* @grypp
-/mlir/**/NVVM*/
+/mlir/**/LLVMIR/**/BasicPtxBuilderInterface* @grypp
+/mlir/**/NVVM*/ @grypp
# BOLT
/bolt/ @aaupov @maksfb @rafaelauler @ayermolo @dcci
More information about the llvm-commits
mailing list