[llvm] Revert "[llvm] Include LLVM_REPOSITORY and LLVM_REVISION in tool version" (PR #85879)

via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 19 17:17:12 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-llvm-support

Author: Jonas Devlieghere (JDevlieghere)

<details>
<summary>Changes</summary>

Reverts llvm/llvm-project#<!-- -->84990 because this causes a full rebuild after the commit hash changes. 

---
Full diff: https://github.com/llvm/llvm-project/pull/85879.diff


2 Files Affected:

- (modified) llvm/lib/Support/CMakeLists.txt (-3) 
- (modified) llvm/lib/Support/CommandLine.cpp (+1-10) 


``````````diff
diff --git a/llvm/lib/Support/CMakeLists.txt b/llvm/lib/Support/CMakeLists.txt
index da2a4b4cdec568..e18beddf7bc5b7 100644
--- a/llvm/lib/Support/CMakeLists.txt
+++ b/llvm/lib/Support/CMakeLists.txt
@@ -288,9 +288,6 @@ add_llvm_component_library(LLVMSupport
   ${LLVM_MAIN_INCLUDE_DIR}/llvm/Support
   ${Backtrace_INCLUDE_DIRS}
 
-  DEPENDS
-  llvm_vcsrevision_h
-
   LINK_LIBS
   ${system_libs} ${imported_libs} ${delayload_flags}
 
diff --git a/llvm/lib/Support/CommandLine.cpp b/llvm/lib/Support/CommandLine.cpp
index 42dbc4de200303..c076ae8b843179 100644
--- a/llvm/lib/Support/CommandLine.cpp
+++ b/llvm/lib/Support/CommandLine.cpp
@@ -39,7 +39,6 @@
 #include "llvm/Support/Path.h"
 #include "llvm/Support/Process.h"
 #include "llvm/Support/StringSaver.h"
-#include "llvm/Support/VCSRevision.h"
 #include "llvm/Support/VirtualFileSystem.h"
 #include "llvm/Support/raw_ostream.h"
 #include <cstdlib>
@@ -2539,15 +2538,7 @@ class VersionPrinter {
 #else
     OS << "LLVM (http://llvm.org/):\n  ";
 #endif
-    OS << PACKAGE_NAME << " version " << PACKAGE_VERSION;
-#ifdef LLVM_REPOSITORY
-    OS << " (" << LLVM_REPOSITORY;
-#ifdef LLVM_REVISION
-    OS << ' ' << LLVM_REVISION;
-#endif
-    OS << ')';
-#endif
-    OS << "\n  ";
+    OS << PACKAGE_NAME << " version " << PACKAGE_VERSION << "\n  ";
 #if LLVM_IS_DEBUG_BUILD
     OS << "DEBUG build";
 #else

``````````

</details>


https://github.com/llvm/llvm-project/pull/85879


More information about the llvm-commits mailing list