[llvm] Enable exp10 libcall on linux (PR #68736)
Krishna Narayanan via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 19 07:46:45 PDT 2024
https://github.com/Krishna-13-cyber updated https://github.com/llvm/llvm-project/pull/68736
>From 673d2eb0ecac779f7052c46d68b78a04218c70e2 Mon Sep 17 00:00:00 2001
From: Krishna-13-cyber <krishnanarayanan132002 at gmail.com>
Date: Mon, 15 Jan 2024 19:48:12 +0530
Subject: [PATCH 1/8] Update with test-cases
---
llvm/lib/Analysis/TargetLibraryInfo.cpp | 12 +++---
.../InstCombine/double-float-shrink-1.ll | 19 +++++++---
llvm/test/Transforms/InstCombine/pow-exp.ll | 37 ++++++++++---------
3 files changed, 40 insertions(+), 28 deletions(-)
diff --git a/llvm/lib/Analysis/TargetLibraryInfo.cpp b/llvm/lib/Analysis/TargetLibraryInfo.cpp
index bbb7c86d21856d..7ec4d3438c85d1 100644
--- a/llvm/lib/Analysis/TargetLibraryInfo.cpp
+++ b/llvm/lib/Analysis/TargetLibraryInfo.cpp
@@ -562,12 +562,9 @@ static void initialize(TargetLibraryInfoImpl &TLI, const Triple &T,
// or we have a reasonable detection strategy, we cannot use exp10 reliably
// on Linux.
//
- // Fall through to disable all of them.
- [[fallthrough]];
- default:
- TLI.setUnavailable(LibFunc_exp10);
- TLI.setUnavailable(LibFunc_exp10f);
- TLI.setUnavailable(LibFunc_exp10l);
+ TLI.setAvailableWithName(LibFunc_exp10, "__exp10");
+ TLI.setAvailableWithName(LibFunc_exp10f, "__exp10f");
+ break;
}
// ffsl is available on at least Darwin, Mac OS X, iOS, FreeBSD, and
@@ -834,6 +831,9 @@ static void initialize(TargetLibraryInfoImpl &TLI, const Triple &T,
TLI.setUnavailable(LibFunc_strndup);
TLI.setUnavailable(LibFunc_strnlen);
TLI.setUnavailable(LibFunc_toascii);
+ TLI.setUnavailable(LibFunc_exp10);
+ TLI.setUnavailable(LibFunc_exp10f);
+ TLI.setUnavailable(LibFunc_exp10l);
}
// As currently implemented in clang, NVPTX code has no standard library to
diff --git a/llvm/test/Transforms/InstCombine/double-float-shrink-1.ll b/llvm/test/Transforms/InstCombine/double-float-shrink-1.ll
index 85c9a01e5fabab..693730256b6b0c 100644
--- a/llvm/test/Transforms/InstCombine/double-float-shrink-1.ll
+++ b/llvm/test/Transforms/InstCombine/double-float-shrink-1.ll
@@ -224,11 +224,20 @@ define double @expm1_test2(float %f) {
; exp10f() doesn't exist for this triple, so it doesn't shrink.
define float @exp10_test1(float %f) {
-; CHECK-LABEL: @exp10_test1(
-; CHECK-NEXT: [[CONV:%.*]] = fpext float [[F:%.*]] to double
-; CHECK-NEXT: [[CALL:%.*]] = call fast double @exp10(double [[CONV]])
-; CHECK-NEXT: [[CONV1:%.*]] = fptrunc double [[CALL]] to float
-; CHECK-NEXT: ret float [[CONV1]]
+; LINUX-LABEL: define float @exp10_test1(
+; LINUX-SAME: float [[F:%.*]]) {
+; LINUX-NEXT: [[EXP10F:%.*]] = call fast float @__exp10f(float [[F]])
+; LINUX-NEXT: ret float [[EXP10F]]
+;
+; MS64-LABEL: define float @exp10_test1(
+; MS64-SAME: float [[F:%.*]]) {
+; MS64-NEXT: [[EXP10F:%.*]] = call fast float @exp10f(float [[F]])
+; MS64-NEXT: ret float [[EXP10F]]
+;
+; MS32-LABEL: define float @exp10_test1(
+; MS32-SAME: float [[F:%.*]]) {
+; MS32-NEXT: [[EXP10F:%.*]] = call fast float @exp10f(float [[F]])
+; MS32-NEXT: ret float [[EXP10F]]
;
%conv = fpext float %f to double
%call = call fast double @exp10(double %conv)
diff --git a/llvm/test/Transforms/InstCombine/pow-exp.ll b/llvm/test/Transforms/InstCombine/pow-exp.ll
index 9d91ad2402eb1d..1271f02a67cc7d 100644
--- a/llvm/test/Transforms/InstCombine/pow-exp.ll
+++ b/llvm/test/Transforms/InstCombine/pow-exp.ll
@@ -139,9 +139,10 @@ define fp128 @powl_exp2l_not_fast(fp128 %x, fp128 %y) {
; TODO: exp10() is not widely enabled by many targets yet.
define float @powf_exp10f(float %x, float %y) {
-; CHECK-LABEL: @powf_exp10f(
-; CHECK-NEXT: [[CALL:%.*]] = call fast float @exp10f(float [[X:%.*]]) #[[ATTR1:[0-9]+]]
-; CHECK-NEXT: [[POW:%.*]] = call fast float @llvm.pow.f32(float [[CALL]], float [[Y:%.*]])
+; CHECK-LABEL: define float @powf_exp10f(
+; CHECK-SAME: float [[X:%.*]], float [[Y:%.*]]) {
+; CHECK-NEXT: [[CALL:%.*]] = call fast float @exp10f(float [[X]]) #[[ATTR1:[0-9]+]]
+; CHECK-NEXT: [[POW:%.*]] = call fast float @llvm.pow.f32(float [[CALL]], float [[Y]])
; CHECK-NEXT: ret float [[POW]]
;
%call = call fast float @exp10f(float %x) nounwind readnone
@@ -150,9 +151,10 @@ define float @powf_exp10f(float %x, float %y) {
}
define double @pow_exp10(double %x, double %y) {
-; CHECK-LABEL: @pow_exp10(
-; CHECK-NEXT: [[CALL:%.*]] = call fast double @exp10(double [[X:%.*]]) #[[ATTR1]]
-; CHECK-NEXT: [[POW:%.*]] = call fast double @llvm.pow.f64(double [[CALL]], double [[Y:%.*]])
+; CHECK-LABEL: define double @pow_exp10(
+; CHECK-SAME: double [[X:%.*]], double [[Y:%.*]]) {
+; CHECK-NEXT: [[CALL:%.*]] = call fast double @exp10(double [[X]]) #[[ATTR1]]
+; CHECK-NEXT: [[POW:%.*]] = call fast double @llvm.pow.f64(double [[CALL]], double [[Y]])
; CHECK-NEXT: ret double [[POW]]
;
%call = call fast double @exp10(double %x) nounwind readnone
@@ -161,9 +163,10 @@ define double @pow_exp10(double %x, double %y) {
}
define fp128 @pow_exp10l(fp128 %x, fp128 %y) {
-; CHECK-LABEL: @pow_exp10l(
-; CHECK-NEXT: [[CALL:%.*]] = call fast fp128 @exp10l(fp128 [[X:%.*]]) #[[ATTR1]]
-; CHECK-NEXT: [[POW:%.*]] = call fast fp128 @llvm.pow.f128(fp128 [[CALL]], fp128 [[Y:%.*]])
+; CHECK-LABEL: define fp128 @pow_exp10l(
+; CHECK-SAME: fp128 [[X:%.*]], fp128 [[Y:%.*]]) {
+; CHECK-NEXT: [[CALL:%.*]] = call fast fp128 @exp10l(fp128 [[X]]) #[[ATTR1]]
+; CHECK-NEXT: [[POW:%.*]] = call fast fp128 @llvm.pow.f128(fp128 [[CALL]], fp128 [[Y]])
; CHECK-NEXT: ret fp128 [[POW]]
;
%call = call fast fp128 @exp10l(fp128 %x) nounwind readnone
@@ -255,10 +258,10 @@ define double @pow_ok_base3(double %e) {
}
define double @pow_ok_ten_base(double %e) {
-; CHECK-LABEL: @pow_ok_ten_base(
-; CHECK-NEXT: [[MUL:%.*]] = fmul nnan ninf afn double [[E:%.*]], 0x400A934F{{.*}}
-; CHECK-NEXT: [[EXP2:%.*]] = tail call nnan ninf afn double @exp2(double [[MUL]])
-; CHECK-NEXT: ret double [[EXP2]]
+; CHECK-LABEL: define double @pow_ok_ten_base(
+; CHECK-SAME: double [[E:%.*]]) {
+; CHECK-NEXT: [[EXP10:%.*]] = tail call nnan ninf afn double @exp10(double [[E]])
+; CHECK-NEXT: ret double [[EXP10]]
;
%call = tail call afn nnan ninf double @pow(double 1.000000e+01, double %e)
ret double %call
@@ -305,10 +308,10 @@ define float @powf_ok_base3(float %e) {
}
define float @powf_ok_ten_base(float %e) {
-; CHECK-LABEL: @powf_ok_ten_base(
-; CHECK-NEXT: [[MUL:%.*]] = fmul nnan ninf afn float [[E:%.*]], 0x400A934{{.*}}
-; CHECK-NEXT: [[EXP2F:%.*]] = tail call nnan ninf afn float @exp2f(float [[MUL]])
-; CHECK-NEXT: ret float [[EXP2F]]
+; CHECK-LABEL: define float @powf_ok_ten_base(
+; CHECK-SAME: float [[E:%.*]]) {
+; CHECK-NEXT: [[EXP10F:%.*]] = tail call nnan ninf afn float @exp10f(float [[E]])
+; CHECK-NEXT: ret float [[EXP10F]]
;
%call = tail call afn nnan ninf float @powf(float 1.000000e+01, float %e)
ret float %call
>From ffb411aea00fb10167174e2204ecee463328c37e Mon Sep 17 00:00:00 2001
From: Krishna Narayanan <krishnanarayanan132002 at gmail.com>
Date: Wed, 17 Jan 2024 22:26:03 +0530
Subject: [PATCH 2/8] Remove stale TODO
---
llvm/test/Transforms/InstCombine/pow-exp.ll | 2 --
1 file changed, 2 deletions(-)
diff --git a/llvm/test/Transforms/InstCombine/pow-exp.ll b/llvm/test/Transforms/InstCombine/pow-exp.ll
index 1271f02a67cc7d..177dd9885827f5 100644
--- a/llvm/test/Transforms/InstCombine/pow-exp.ll
+++ b/llvm/test/Transforms/InstCombine/pow-exp.ll
@@ -136,8 +136,6 @@ define fp128 @powl_exp2l_not_fast(fp128 %x, fp128 %y) {
ret fp128 %pow
}
-; TODO: exp10() is not widely enabled by many targets yet.
-
define float @powf_exp10f(float %x, float %y) {
; CHECK-LABEL: define float @powf_exp10f(
; CHECK-SAME: float [[X:%.*]], float [[Y:%.*]]) {
>From ed38fb5aecc51f06aefc2b28cbae8f45d915724e Mon Sep 17 00:00:00 2001
From: Krishna-13-cyber <krishnanarayanan132002 at gmail.com>
Date: Sat, 27 Jan 2024 13:52:08 +0530
Subject: [PATCH 3/8] Update with exp10l
---
llvm/lib/Analysis/TargetLibraryInfo.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/llvm/lib/Analysis/TargetLibraryInfo.cpp b/llvm/lib/Analysis/TargetLibraryInfo.cpp
index 7ec4d3438c85d1..5b8024e6b350bd 100644
--- a/llvm/lib/Analysis/TargetLibraryInfo.cpp
+++ b/llvm/lib/Analysis/TargetLibraryInfo.cpp
@@ -564,6 +564,7 @@ static void initialize(TargetLibraryInfoImpl &TLI, const Triple &T,
//
TLI.setAvailableWithName(LibFunc_exp10, "__exp10");
TLI.setAvailableWithName(LibFunc_exp10f, "__exp10f");
+ TLI.setAvailableWithName(LibFunc_exp10l, "__exp10l");
break;
}
>From c23b6a5c01d9c792a3de26e69b265d41c0b678e9 Mon Sep 17 00:00:00 2001
From: Krishna-13-cyber <krishnanarayanan132002 at gmail.com>
Date: Tue, 6 Feb 2024 19:24:20 +0530
Subject: [PATCH 4/8] Update with removing redundant comments
---
llvm/lib/Analysis/TargetLibraryInfo.cpp | 5 -----
1 file changed, 5 deletions(-)
diff --git a/llvm/lib/Analysis/TargetLibraryInfo.cpp b/llvm/lib/Analysis/TargetLibraryInfo.cpp
index 5b8024e6b350bd..288a5fa4147419 100644
--- a/llvm/lib/Analysis/TargetLibraryInfo.cpp
+++ b/llvm/lib/Analysis/TargetLibraryInfo.cpp
@@ -557,11 +557,6 @@ static void initialize(TargetLibraryInfoImpl &TLI, const Triple &T,
}
break;
case Triple::Linux:
- // exp10, exp10f, exp10l is available on Linux (GLIBC) but are extremely
- // buggy prior to glibc version 2.18. Until this version is widely deployed
- // or we have a reasonable detection strategy, we cannot use exp10 reliably
- // on Linux.
- //
TLI.setAvailableWithName(LibFunc_exp10, "__exp10");
TLI.setAvailableWithName(LibFunc_exp10f, "__exp10f");
TLI.setAvailableWithName(LibFunc_exp10l, "__exp10l");
>From cfb9f6b7fd511f038a50ef090c6b9d7570720efd Mon Sep 17 00:00:00 2001
From: Krishna-13-cyber <krishnanarayanan132002 at gmail.com>
Date: Fri, 1 Mar 2024 21:10:11 +0530
Subject: [PATCH 5/8] Update with note
---
llvm/lib/Analysis/TargetLibraryInfo.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/llvm/lib/Analysis/TargetLibraryInfo.cpp b/llvm/lib/Analysis/TargetLibraryInfo.cpp
index 288a5fa4147419..93031f1211b1cb 100644
--- a/llvm/lib/Analysis/TargetLibraryInfo.cpp
+++ b/llvm/lib/Analysis/TargetLibraryInfo.cpp
@@ -557,6 +557,7 @@ static void initialize(TargetLibraryInfoImpl &TLI, const Triple &T,
}
break;
case Triple::Linux:
+ // As this version is so old, we don't really need to worry about using exp10
TLI.setAvailableWithName(LibFunc_exp10, "__exp10");
TLI.setAvailableWithName(LibFunc_exp10f, "__exp10f");
TLI.setAvailableWithName(LibFunc_exp10l, "__exp10l");
>From 866dafe756d561de14df9ce0f15e259924e741e9 Mon Sep 17 00:00:00 2001
From: Krishna-13-cyber <krishnanarayanan132002 at gmail.com>
Date: Fri, 1 Mar 2024 21:36:59 +0530
Subject: [PATCH 6/8] Update with clang-format
---
llvm/lib/Analysis/TargetLibraryInfo.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/llvm/lib/Analysis/TargetLibraryInfo.cpp b/llvm/lib/Analysis/TargetLibraryInfo.cpp
index 93031f1211b1cb..f08f52f685c242 100644
--- a/llvm/lib/Analysis/TargetLibraryInfo.cpp
+++ b/llvm/lib/Analysis/TargetLibraryInfo.cpp
@@ -557,7 +557,8 @@ static void initialize(TargetLibraryInfoImpl &TLI, const Triple &T,
}
break;
case Triple::Linux:
- // As this version is so old, we don't really need to worry about using exp10
+ // As this version is so old, we don't really need to worry about using
+ // exp10
TLI.setAvailableWithName(LibFunc_exp10, "__exp10");
TLI.setAvailableWithName(LibFunc_exp10f, "__exp10f");
TLI.setAvailableWithName(LibFunc_exp10l, "__exp10l");
>From ea765fe497bec5c66fba8f1fc816f5f014b52962 Mon Sep 17 00:00:00 2001
From: Krishna-13-cyber <krishnanarayanan132002 at gmail.com>
Date: Wed, 6 Mar 2024 12:58:32 +0530
Subject: [PATCH 7/8] Update with version in note
---
llvm/lib/Analysis/TargetLibraryInfo.cpp | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/llvm/lib/Analysis/TargetLibraryInfo.cpp b/llvm/lib/Analysis/TargetLibraryInfo.cpp
index f08f52f685c242..27a1bc8338dfb7 100644
--- a/llvm/lib/Analysis/TargetLibraryInfo.cpp
+++ b/llvm/lib/Analysis/TargetLibraryInfo.cpp
@@ -557,8 +557,9 @@ static void initialize(TargetLibraryInfoImpl &TLI, const Triple &T,
}
break;
case Triple::Linux:
- // As this version is so old, we don't really need to worry about using
- // exp10
+ // exp10, exp10f, exp10l is available on Linux (GLIBC) but are extremely
+ // buggy prior to glibc version 2.18. As this version is so old, we
+ // don't really need to worry about using exp10 on Linux.
TLI.setAvailableWithName(LibFunc_exp10, "__exp10");
TLI.setAvailableWithName(LibFunc_exp10f, "__exp10f");
TLI.setAvailableWithName(LibFunc_exp10l, "__exp10l");
>From 107e3722225ff096bebf2b0860c571abb8b57abf Mon Sep 17 00:00:00 2001
From: Krishna-13-cyber <krishnanarayanan132002 at gmail.com>
Date: Tue, 19 Mar 2024 20:15:57 +0530
Subject: [PATCH 8/8] Update pow-1.ll test with generated checks
---
llvm/test/Transforms/InstCombine/pow-1.ll | 53 +++++++++++++++++++----
1 file changed, 45 insertions(+), 8 deletions(-)
diff --git a/llvm/test/Transforms/InstCombine/pow-1.ll b/llvm/test/Transforms/InstCombine/pow-1.ll
index 7a72902126f84e..5024d152bddf55 100644
--- a/llvm/test/Transforms/InstCombine/pow-1.ll
+++ b/llvm/test/Transforms/InstCombine/pow-1.ll
@@ -870,10 +870,30 @@ define float @test_simplify18(float %x) {
; CHECK-EXP10-NEXT: [[__EXP10F:%.*]] = call float @__exp10f(float [[X]])
; CHECK-EXP10-NEXT: ret float [[__EXP10F]]
;
-; CHECK-NO-EXP10-LABEL: define float @test_simplify18(
-; CHECK-NO-EXP10-SAME: float [[X:%.*]]) {
-; CHECK-NO-EXP10-NEXT: [[RETVAL:%.*]] = call float @powf(float 1.000000e+01, float [[X]])
-; CHECK-NO-EXP10-NEXT: ret float [[RETVAL]]
+; VC32-LABEL: define float @test_simplify18(
+; VC32-SAME: float [[X:%.*]]) {
+; VC32-NEXT: [[RETVAL:%.*]] = call float @powf(float 1.000000e+01, float [[X]])
+; VC32-NEXT: ret float [[RETVAL]]
+;
+; VC51-LABEL: define float @test_simplify18(
+; VC51-SAME: float [[X:%.*]]) {
+; VC51-NEXT: [[RETVAL:%.*]] = call float @powf(float 1.000000e+01, float [[X]])
+; VC51-NEXT: ret float [[RETVAL]]
+;
+; VC64-LABEL: define float @test_simplify18(
+; VC64-SAME: float [[X:%.*]]) {
+; VC64-NEXT: [[EXP10F:%.*]] = call float @exp10f(float [[X]])
+; VC64-NEXT: ret float [[EXP10F]]
+;
+; VC83-LABEL: define float @test_simplify18(
+; VC83-SAME: float [[X:%.*]]) {
+; VC83-NEXT: [[EXP10F:%.*]] = call float @exp10f(float [[X]])
+; VC83-NEXT: ret float [[EXP10F]]
+;
+; NOLIB-LABEL: define float @test_simplify18(
+; NOLIB-SAME: float [[X:%.*]]) {
+; NOLIB-NEXT: [[RETVAL:%.*]] = call float @powf(float 1.000000e+01, float [[X]])
+; NOLIB-NEXT: ret float [[RETVAL]]
;
%retval = call float @powf(float 10.0, float %x)
ret float %retval
@@ -885,11 +905,28 @@ define double @test_simplify19(double %x) {
; CHECK-EXP10-NEXT: [[__EXP10:%.*]] = call double @__exp10(double [[X]])
; CHECK-EXP10-NEXT: ret double [[__EXP10]]
;
-; CHECK-NO-EXP10-LABEL: define double @test_simplify19(
-; CHECK-NO-EXP10-SAME: double [[X:%.*]]) {
-; CHECK-NO-EXP10-NEXT: [[RETVAL:%.*]] = call double @pow(double 1.000000e+01, double [[X]])
-; CHECK-NO-EXP10-NEXT: ret double [[RETVAL]]
+; VC32-LABEL: define double @test_simplify19(
+; VC32-SAME: double [[X:%.*]]) {
+; VC32-NEXT: [[EXP10:%.*]] = call double @exp10(double [[X]])
+; VC32-NEXT: ret double [[EXP10]]
+;
+; VC19-LABEL: define double @test_simplify19(
+; VC19-SAME: double [[X:%.*]]) {
+; VC19-NEXT: [[EXP10:%.*]] = call double @exp10(double [[X]])
+; VC19-NEXT: ret double [[EXP10]]
+;
+; VC64-LABEL: define double @test_simplify19(
+; VC64-SAME: double [[X:%.*]]) {
+; VC64-NEXT: [[EXP10:%.*]] = call double @exp10(double [[X]])
+; VC64-NEXT: ret double [[EXP10]]
+;
+; NOLIB-LABEL: define double @test_simplify19(
+; NOLIB-SAME: double [[X:%.*]]) {
+; NOLIB-NEXT: [[RETVAL:%.*]] = call double @pow(double 1.000000e+01, double [[X]])
+; NOLIB-NEXT: ret double [[RETVAL]]
;
%retval = call double @pow(double 10.0, double %x)
ret double %retval
}
+;; NOTE: These prefixes are unused and the list is autogenerated. Do not add tests below this line:
+; CHECK-NO-EXP10: {{.*}}
More information about the llvm-commits
mailing list