[llvm] [AMDGPU] Support double type in atomic optimizer. (PR #84307)
Matt Arsenault via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 19 03:48:55 PDT 2024
================
@@ -1,1170 +1,1623 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-; RUN: opt -S -mtriple=amdgcn-- -mcpu=gfx906 -amdgpu-atomic-optimizer-strategy=Iterative -passes='amdgpu-atomic-optimizer,verify<domtree>' %s | FileCheck -check-prefix=IR-ITERATIVE %s
-; RUN: opt -S -mtriple=amdgcn-- -mcpu=gfx906 -amdgpu-atomic-optimizer-strategy=DPP -passes='amdgpu-atomic-optimizer,verify<domtree>' %s | FileCheck -check-prefix=IR-DPP %s
+; RUN: opt -S -mtriple=amdgcn-- -mcpu=gfx906 -amdgpu-atomic-optimizer-strategy=Iterative -passes='amdgpu-atomic-optimizer,verify<domtree>' %s | FileCheck --check-prefixes=UNIFORM-VAL,DIV-VAL-ITERATIVE %s
----------------
arsenm wrote:
UNIFORM/DIV are not good check prefixes to use. It only makes sense if you're totally sure about the content of the test changes. It's better if they are descriptive of just the run itself. It's also better to not change the base checks in the change commit. I would suggest keeping IR-ITERATIVE/IR-DPP, and just adding "IR" as the common prefix
https://github.com/llvm/llvm-project/pull/84307
More information about the llvm-commits
mailing list