[llvm] AMDGPU: Treat SWMMAC the same as MFMA and other WMMA for sched_barrier (PR #85721)

Stanislav Mekhanoshin via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 19 00:44:34 PDT 2024


================
@@ -0,0 +1,333 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=amdgcn -mcpu=gfx1200 -verify-machineinstrs -misched-cluster=0 < %s | FileCheck -check-prefix=GCN %s
----------------
rampitec wrote:

> It's brutally expensive. Unless you are adding a test for a case that hits a verifier error, it's probably not worth it. We've traditionally blindly added it to every test. The expensive checks bits will get it eventually if it does fail the verifier

This changes the guidelines. Particularly your own guidelines. I really want to understand where is a borderline between a 'brutally expensive' and normal. I remember the times when every review was down because it was missing this flag. Shall we just omit it always now, because it will eventually fail with expensive checks? I mean, I am not opposed. But there shall be a common policy.

https://github.com/llvm/llvm-project/pull/85721


More information about the llvm-commits mailing list