[compiler-rt] [compiler-rt] Avoid pulling in __cxa_pure_virtual (PR #84613)
Alexander Richardson via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 18 17:22:48 PDT 2024
https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/84613
>From 47c68a2a61585ea33b8df3a475dee2e31ed54ab4 Mon Sep 17 00:00:00 2001
From: Alex Richardson <alexrichardson at google.com>
Date: Fri, 8 Mar 2024 23:59:13 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
=?UTF-8?q?l=20version?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Created using spr 1.3.6-beta.1
---
.../sanitizer_common/sanitizer_stacktrace_printer.h | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_stacktrace_printer.h b/compiler-rt/lib/sanitizer_common/sanitizer_stacktrace_printer.h
index 10361a32034452..869eab9352c4c1 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_stacktrace_printer.h
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_stacktrace_printer.h
@@ -30,10 +30,13 @@ class StackTracePrinter {
virtual void RenderFrame(InternalScopedString *buffer, const char *format,
int frame_no, uptr address, const AddressInfo *info,
- bool vs_style,
- const char *strip_path_prefix = "") = 0;
+ bool vs_style, const char *strip_path_prefix = "") {
+ Abort(); // Should be pure virtual but avoid pulling in __cxa_pure_virtual.
+ }
- virtual bool RenderNeedsSymbolization(const char *format) = 0;
+ virtual bool RenderNeedsSymbolization(const char *format) {
+ Abort(); // Should be pure virtual but avoid pulling in __cxa_pure_virtual.
+ }
void RenderSourceLocation(InternalScopedString *buffer, const char *file,
int line, int column, bool vs_style,
@@ -44,7 +47,9 @@ class StackTracePrinter {
const char *strip_path_prefix);
virtual void RenderData(InternalScopedString *buffer, const char *format,
const DataInfo *DI,
- const char *strip_path_prefix = "") = 0;
+ const char *strip_path_prefix = "") {
+ Abort(); // Should be pure virtual but avoid pulling in __cxa_pure_virtual.
+ }
private:
// To be called from StackTracePrinter::GetOrInit
More information about the llvm-commits
mailing list