[llvm] 18da51b - [CodeGen] More uses of LocationSize::beforeOrAfterPointer().

David Green via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 18 13:18:54 PDT 2024


Author: David Green
Date: 2024-03-18T20:18:49Z
New Revision: 18da51b2b227bcaee0efd13c4bc9ba408ea6b6e6

URL: https://github.com/llvm/llvm-project/commit/18da51b2b227bcaee0efd13c4bc9ba408ea6b6e6
DIFF: https://github.com/llvm/llvm-project/commit/18da51b2b227bcaee0efd13c4bc9ba408ea6b6e6.diff

LOG: [CodeGen] More uses of LocationSize::beforeOrAfterPointer().

As an extension to #84751, this adds some extra uses of beforeOrAfterPointer()
instead of UnknownSize.

Added: 
    

Modified: 
    llvm/include/llvm/Analysis/MemoryLocation.h
    llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
    llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Analysis/MemoryLocation.h b/llvm/include/llvm/Analysis/MemoryLocation.h
index 6d3d0acc2076d4..830eed5d60ee46 100644
--- a/llvm/include/llvm/Analysis/MemoryLocation.h
+++ b/llvm/include/llvm/Analysis/MemoryLocation.h
@@ -298,7 +298,7 @@ class MemoryLocation {
   }
 
   // Return the exact size if the exact size is known at compiletime,
-  // otherwise return MemoryLocation::UnknownSize.
+  // otherwise return LocationSize::beforeOrAfterPointer().
   static LocationSize getSizeOrUnknown(const TypeSize &T) {
     return T.isScalable() ? LocationSize::beforeOrAfterPointer()
                           : LocationSize::precise(T.getFixedValue());

diff  --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
index 2670f48aebcff5..fc2517ea7ef081 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
@@ -8395,7 +8395,7 @@ SDValue SelectionDAG::getMemIntrinsicNode(
     MachineMemOperand::Flags Flags, LocationSize Size,
     const AAMDNodes &AAInfo) {
   if (Size.hasValue() && MemVT.isScalableVector())
-    Size = MemoryLocation::UnknownSize;
+    Size = LocationSize::beforeOrAfterPointer();
   else if (Size.hasValue() && !Size.getValue())
     Size = LocationSize::precise(MemVT.getStoreSize());
 

diff  --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
index f1923a64368f4f..8780f4b931484f 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
@@ -4858,9 +4858,7 @@ void SelectionDAGBuilder::visitMaskedScatter(const CallInst &I) {
   unsigned AS = Ptr->getType()->getScalarType()->getPointerAddressSpace();
   MachineMemOperand *MMO = DAG.getMachineFunction().getMachineMemOperand(
       MachinePointerInfo(AS), MachineMemOperand::MOStore,
-      // TODO: Make MachineMemOperands aware of scalable
-      // vectors.
-      MemoryLocation::UnknownSize, Alignment, I.getAAMetadata());
+      LocationSize::beforeOrAfterPointer(), Alignment, I.getAAMetadata());
   if (!UniformBase) {
     Base = DAG.getConstant(0, sdl, TLI.getPointerTy(DAG.getDataLayout()));
     Index = getValue(Ptr);
@@ -4962,9 +4960,7 @@ void SelectionDAGBuilder::visitMaskedGather(const CallInst &I) {
   unsigned AS = Ptr->getType()->getScalarType()->getPointerAddressSpace();
   MachineMemOperand *MMO = DAG.getMachineFunction().getMachineMemOperand(
       MachinePointerInfo(AS), MachineMemOperand::MOLoad,
-      // TODO: Make MachineMemOperands aware of scalable
-      // vectors.
-      MemoryLocation::UnknownSize, Alignment, I.getAAMetadata(), Ranges);
+      LocationSize::beforeOrAfterPointer(), Alignment, I.getAAMetadata(), Ranges);
 
   if (!UniformBase) {
     Base = DAG.getConstant(0, sdl, TLI.getPointerTy(DAG.getDataLayout()));


        


More information about the llvm-commits mailing list