[llvm] [Object][Archive][NFC] Create all symbolic files objects before calculating offsets. (PR #85229)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 18 02:52:54 PDT 2024


jh7370 wrote:

I think this PR could have done with some eyes from the AIX developer (@diggerlin, I think) and myself as people previously involved (and not all that long ago) with this area of code.

Taking a look at the change, I'm a little concerned about the potential impact on memory usage of this version of the PR. Previously, the code would only need one symbolic file to be in memory at a time, but now it requires all of them. I don't have any numbers, but I wouldn't be surprised in a large archive with many members with lots of symbols (not an unusual thing) if this change has drastically increased memory usage. I think it would be a good idea to do some performance analysis of the before and after of this change for particularly large archives.

https://github.com/llvm/llvm-project/pull/85229


More information about the llvm-commits mailing list