[llvm] [SelectionDAG] Resolve TODO: Use signedAddMayOverflow (PR #85586)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 17 21:18:14 PDT 2024


================
@@ -4125,8 +4125,13 @@ SelectionDAG::computeOverflowForSignedAdd(SDValue N0, SDValue N1) const {
   if (ComputeNumSignBits(N0) > 1 && ComputeNumSignBits(N1) > 1)
     return OFK_Never;
 
-  // TODO: Add ConstantRange::signedAddMayOverflow handling.
-  return OFK_Sometime;
+  KnownBits N0Known = computeKnownBits(N0);
+  KnownBits N1Known = computeKnownBits(N1);
----------------
arsenm wrote:

can early exit if first query didn't report anything useful 

https://github.com/llvm/llvm-project/pull/85586


More information about the llvm-commits mailing list