[llvm] [TableGen] fix tlbgen for EncodingByHwMode (PR #84906)

via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 17 08:48:46 PDT 2024


superZWT123 wrote:

> > @nvjle @topperc Hello, could you please help me review my code.
> 
> @superZWT123 Please give me a day or two to review this code. From a very quick scan, it actually undoes some of the work I did recently (or at least does it differently)-- which may be fine-- but I need to examine carefully. I'm using this feature in a downstream production backend with a complicated ISA (generously speaking) and even more complicated encoding schemes (100+ decoder tables). It tends to exercise the encode/decode heavily.
> 
> Also, my previous patch to suppress duplicates had a command line option so that existing downstream backends could opt-in to that feature-- at least temporarily. That is, a downstream backend could rebase and their disassembler would not need any changes due to decoder table naming. Something like that would probably be good to keep initially.
> 
> All of that said, I am certainly glad to see others helping to production-harden this feature.

Hi [nvjle](https://github.com/nvjle).
I hope all is well with you. Since you mentioned needing a day or two to carefully review my code, three days have now passed, and I’m curious if you’ve had the opportunity to complete your review. Are there any suggestions or adjustments you’d like me to make? If not, may I proceed with merging my code into the main branch?
I look forward to your valuable feedback. Thanks!


https://github.com/llvm/llvm-project/pull/84906


More information about the llvm-commits mailing list