[llvm] [llvm-shlib] Fix libLLVM-18 symlink on mingw (PR #85554)

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 16 14:55:36 PDT 2024


https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/85554

The TARGET_SONAME_FILE_NAME generator expression is not available on dll target platforms.

>From c8ca6b383d7303fed6afd472cc4a5bdd94598d00 Mon Sep 17 00:00:00 2001
From: Tom Stellard <tstellar at redhat.com>
Date: Sat, 16 Mar 2024 21:46:55 +0000
Subject: [PATCH] [llvm-shlib] Fix libLLVM-18 symlink on mingw

The TARGET_SONAME_FILE_NAME generator expression is not available on
dll target platforms.
---
 llvm/tools/llvm-shlib/CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/tools/llvm-shlib/CMakeLists.txt b/llvm/tools/llvm-shlib/CMakeLists.txt
index 9adce0617ff736..0ad350bcbe0d7b 100644
--- a/llvm/tools/llvm-shlib/CMakeLists.txt
+++ b/llvm/tools/llvm-shlib/CMakeLists.txt
@@ -35,7 +35,7 @@ if(LLVM_BUILD_LLVM_DYLIB)
   endif()
   add_llvm_library(LLVM SHARED DISABLE_LLVM_LINK_LLVM_DYLIB OUTPUT_NAME LLVM ${INSTALL_WITH_TOOLCHAIN} ${SOURCES})
   # Add symlink for backwards compatibility with old library name
-  llvm_install_library_symlink(LLVM-${LLVM_VERSION_MAJOR}${LLVM_VERSION_SUFFIX} $<TARGET_SONAME_FILE_NAME:LLVM> SHARED FULL_DEST COMPONENT LLVM)
+  llvm_install_library_symlink(LLVM-${LLVM_VERSION_MAJOR}${LLVM_VERSION_SUFFIX} $<TARGET_FILE_NAME:LLVM> SHARED FULL_DEST COMPONENT LLVM)
 
   list(REMOVE_DUPLICATES LIB_NAMES)
   if("${CMAKE_SYSTEM_NAME}" STREQUAL "Darwin")



More information about the llvm-commits mailing list