[llvm] [RemoveDIs][NFC] Rename DPValue -> DbgVariableRecord (PR #85216)
Orlando Cazalet-Hyams via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 15 09:43:33 PDT 2024
================
@@ -3225,10 +3225,11 @@ class TypePromotionTransaction {
// correctness and utility of debug value instructions.
for (auto *DVI : DbgValues)
DVI->replaceVariableLocationOp(New, Inst);
- // Similar story with DPValues, the non-instruction representation of
- // dbg.values.
- for (DPValue *DPV : DPValues) // tested by transaction-test I'm adding
- DPV->replaceVariableLocationOp(New, Inst);
+ // Similar story with DbgVariableRecords, the non-instruction
+ // representation of dbg.values.
+ for (DbgVariableRecord *DVR :
+ DbgVariableRecords) // tested by transaction-test I'm adding
----------------
OCHyams wrote:
`// tested by transaction-test I'm adding` looks like a comment someone's added accidentally. IMO better to move it above the loop or delete it, to prevent the weird formatting that happens as a result of lengthening the line with the rename. YMMV.
https://github.com/llvm/llvm-project/pull/85216
More information about the llvm-commits
mailing list