[llvm] [InstCombine] Add contributor guide (PR #79007)

via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 15 08:48:55 PDT 2024


================
@@ -0,0 +1,467 @@
+# InstCombine contributor guide
+
+This guide lays out a series of rules that contributions to InstCombine should
+follow. **Following these rules will results in much faster PR approvals.**
+
+## Tests
+
+### Precommit tests
+
+Tests for new optimizations or miscompilation fixes should be pre-committed.
+This means that you first commit the test with CHECK lines prior to your fix.
----------------
goldsteinn wrote:

'prior to your fix' sounds a bit unclear imo. How about 'without your implementation'?

https://github.com/llvm/llvm-project/pull/79007


More information about the llvm-commits mailing list