[llvm] Add ALLOW_RETRIES to flaky test bg-record-roundtrip.ll (PR #85410)

[Orlando Cazalet-Hyams via llvm-commits]

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/85410

>From a3d1f505000905a13956d67f849324872f7e8205 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
Date: Fri, 15 Mar 2024 14:49:31 +0000
Subject: [PATCH 1/2] Add ALLOW_RETRIES to flaky test
 llvm/test/Bitcode/dbg-record-roundtrip.ll

Something strange is happening in this test.

If the llvm-as output is piped into llvm-link in the final RUN lines then this
test fails on my machine (1 in 200) using WSL2. If the verify-uselistorder RUN
lines are removed then it doesn't fail on my machine (in 10,000+). If the
llvm-as and llvm-link RUN lines mentioned at the start are removed then it
doesn't fail on my machine (in 10,000+).

Writing the llvm-as output to a temporary file for llvm-link to read on those
final RUN lines, the test doesn't fail on my machine (in 10,000+). But it did
fail ona bot: https://lab.llvm.org/buildbot/#/builders/245/builds/21930

Lit says the test fails with one of the tools (verify-uselistorder, by the looks
of it, looking at the bot failure output ending with RUN line 5) exiting with
code 74.
---
 llvm/test/Bitcode/dbg-record-roundtrip.ll | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/llvm/test/Bitcode/dbg-record-roundtrip.ll b/llvm/test/Bitcode/dbg-record-roundtrip.ll
index d092e3822d26b0..e8453a3d5e23f6 100644
--- a/llvm/test/Bitcode/dbg-record-roundtrip.ll
+++ b/llvm/test/Bitcode/dbg-record-roundtrip.ll
@@ -17,6 +17,11 @@
 ;; NOTE: This test fails intermittently on linux if the llvm-as output is piped
 ;; into llvm-link in the RUN lines below, unless the verify-uselistorder RUN
 ;; lines above are removed. Write to a temporary file to avoid that weirdness.
+;; NOTE2: Unfortunately, the above only stopped it occuring on my machine.
+;; It failed again intermittently here:
+;; https://lab.llvm.org/buildbot/#/builders/245/builds/21930
+;; Allow this test to run fail-over twice, until this strangeness is understood.
+; ALLOW_RETRIES: 2
 ; RUN: llvm-as %s --experimental-debuginfo-iterators=true --write-experimental-debuginfo-iterators-to-bitcode=true -o %t
 ; RUN: llvm-link %t %s --experimental-debuginfo-iterators=false -o /dev/null
 ; RUN: llvm-as %s --experimental-debuginfo-iterators=false -o %t

>From 1b27fd20e629aea2a1c34ee005a26d72d3559a87 Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
Date: Fri, 15 Mar 2024 15:08:16 +0000
Subject: [PATCH 2/2] fix words

---
 llvm/test/Bitcode/dbg-record-roundtrip.ll | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/test/Bitcode/dbg-record-roundtrip.ll b/llvm/test/Bitcode/dbg-record-roundtrip.ll
index e8453a3d5e23f6..84606b589e8830 100644
--- a/llvm/test/Bitcode/dbg-record-roundtrip.ll
+++ b/llvm/test/Bitcode/dbg-record-roundtrip.ll
@@ -20,7 +20,7 @@
 ;; NOTE2: Unfortunately, the above only stopped it occuring on my machine.
 ;; It failed again intermittently here:
 ;; https://lab.llvm.org/buildbot/#/builders/245/builds/21930
-;; Allow this test to run fail-over twice, until this strangeness is understood.
+;; Allow this test to fail-over twice, until this strangeness is understood.
 ; ALLOW_RETRIES: 2
 ; RUN: llvm-as %s --experimental-debuginfo-iterators=true --write-experimental-debuginfo-iterators-to-bitcode=true -o %t
 ; RUN: llvm-link %t %s --experimental-debuginfo-iterators=false -o /dev/null