[llvm] fe753f7 - [DAG] visitTRUNCATE - pull out repeated SDLoc(N). NFC.
Simon Pilgrim via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 15 03:24:39 PDT 2024
Author: Simon Pilgrim
Date: 2024-03-15T10:24:19Z
New Revision: fe753f77c35cf236b8aed6b5ebd857973e047925
URL: https://github.com/llvm/llvm-project/commit/fe753f77c35cf236b8aed6b5ebd857973e047925
DIFF: https://github.com/llvm/llvm-project/commit/fe753f77c35cf236b8aed6b5ebd857973e047925.diff
LOG: [DAG] visitTRUNCATE - pull out repeated SDLoc(N). NFC.
Added:
Modified:
llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
Removed:
################################################################################
diff --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
index 1895eaf6d52a00..314cda13fb5c22 100644
--- a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
@@ -14609,6 +14609,7 @@ SDValue DAGCombiner::visitTRUNCATE(SDNode *N) {
EVT VT = N->getValueType(0);
EVT SrcVT = N0.getValueType();
bool isLE = DAG.getDataLayout().isLittleEndian();
+ SDLoc DL(N);
// trunc(undef) = undef
if (N0.isUndef())
@@ -14616,10 +14617,10 @@ SDValue DAGCombiner::visitTRUNCATE(SDNode *N) {
// fold (truncate (truncate x)) -> (truncate x)
if (N0.getOpcode() == ISD::TRUNCATE)
- return DAG.getNode(ISD::TRUNCATE, SDLoc(N), VT, N0.getOperand(0));
+ return DAG.getNode(ISD::TRUNCATE, DL, VT, N0.getOperand(0));
// fold (truncate c1) -> c1
- if (SDValue C = DAG.FoldConstantArithmetic(ISD::TRUNCATE, SDLoc(N), VT, {N0}))
+ if (SDValue C = DAG.FoldConstantArithmetic(ISD::TRUNCATE, DL, VT, {N0}))
return C;
// fold (truncate (ext x)) -> (ext x) or (truncate x) or x
@@ -14628,10 +14629,10 @@ SDValue DAGCombiner::visitTRUNCATE(SDNode *N) {
N0.getOpcode() == ISD::ANY_EXTEND) {
// if the source is smaller than the dest, we still need an extend.
if (N0.getOperand(0).getValueType().bitsLT(VT))
- return DAG.getNode(N0.getOpcode(), SDLoc(N), VT, N0.getOperand(0));
+ return DAG.getNode(N0.getOpcode(), DL, VT, N0.getOperand(0));
// if the source is larger than the dest, than we just need the truncate.
if (N0.getOperand(0).getValueType().bitsGT(VT))
- return DAG.getNode(ISD::TRUNCATE, SDLoc(N), VT, N0.getOperand(0));
+ return DAG.getNode(ISD::TRUNCATE, DL, VT, N0.getOperand(0));
// if the source and dest are the same type, we can drop both the extend
// and the truncate.
return N0.getOperand(0);
@@ -14645,8 +14646,8 @@ SDValue DAGCombiner::visitTRUNCATE(SDNode *N) {
SDValue ExtVal = N0.getOperand(1);
EVT ExtVT = cast<VTSDNode>(ExtVal)->getVT();
if (ExtVT.bitsLT(VT) && TLI.preferSextInRegOfTruncate(VT, SrcVT, ExtVT)) {
- SDValue TrX = DAG.getNode(ISD::TRUNCATE, SDLoc(N), VT, X);
- return DAG.getNode(ISD::SIGN_EXTEND_INREG, SDLoc(N), VT, TrX, ExtVal);
+ SDValue TrX = DAG.getNode(ISD::TRUNCATE, DL, VT, X);
+ return DAG.getNode(ISD::SIGN_EXTEND_INREG, DL, VT, TrX, ExtVal);
}
}
@@ -14681,8 +14682,6 @@ SDValue DAGCombiner::visitTRUNCATE(SDNode *N) {
if (isa<ConstantSDNode>(EltNo) && isTypeLegal(NVT)) {
int Elt = EltNo->getAsZExtVal();
int Index = isLE ? (Elt*SizeRatio) : (Elt*SizeRatio + (SizeRatio-1));
-
- SDLoc DL(N);
return DAG.getNode(ISD::EXTRACT_VECTOR_ELT, DL, TrTy,
DAG.getBitcast(NVT, N0.getOperand(0)),
DAG.getVectorIdxConstant(Index, DL));
@@ -14697,7 +14696,7 @@ SDValue DAGCombiner::visitTRUNCATE(SDNode *N) {
SDValue Cond = N0.getOperand(0);
SDValue TruncOp0 = DAG.getNode(ISD::TRUNCATE, SL, VT, N0.getOperand(1));
SDValue TruncOp1 = DAG.getNode(ISD::TRUNCATE, SL, VT, N0.getOperand(2));
- return DAG.getNode(ISD::SELECT, SDLoc(N), VT, Cond, TruncOp0, TruncOp1);
+ return DAG.getNode(ISD::SELECT, DL, VT, Cond, TruncOp0, TruncOp1);
}
}
@@ -14709,15 +14708,13 @@ SDValue DAGCombiner::visitTRUNCATE(SDNode *N) {
KnownBits Known = DAG.computeKnownBits(Amt);
unsigned Size = VT.getScalarSizeInBits();
if (Known.countMaxActiveBits() <= Log2_32(Size)) {
- SDLoc SL(N);
EVT AmtVT = TLI.getShiftAmountTy(VT, DAG.getDataLayout());
-
- SDValue Trunc = DAG.getNode(ISD::TRUNCATE, SL, VT, N0.getOperand(0));
+ SDValue Trunc = DAG.getNode(ISD::TRUNCATE, DL, VT, N0.getOperand(0));
if (AmtVT != Amt.getValueType()) {
- Amt = DAG.getZExtOrTrunc(Amt, SL, AmtVT);
+ Amt = DAG.getZExtOrTrunc(Amt, DL, AmtVT);
AddToWorklist(Amt.getNode());
}
- return DAG.getNode(ISD::SHL, SL, VT, Trunc, Amt);
+ return DAG.getNode(ISD::SHL, DL, VT, Trunc, Amt);
}
}
@@ -14733,7 +14730,6 @@ SDValue DAGCombiner::visitTRUNCATE(SDNode *N) {
TLI.isTruncateFree(SrcVT.getScalarType(), VT.getScalarType()) &&
// Avoid creating illegal types if running after type legalizer.
(!LegalTypes || TLI.isTypeLegal(VT.getScalarType()))) {
- SDLoc DL(N);
EVT SVT = VT.getScalarType();
SmallVector<SDValue, 8> TruncOps;
for (const SDValue &Op : N0->op_values()) {
@@ -14747,7 +14743,6 @@ SDValue DAGCombiner::visitTRUNCATE(SDNode *N) {
if (N0.getOpcode() == ISD::SPLAT_VECTOR &&
(!LegalTypes || TLI.isTypeLegal(VT.getScalarType())) &&
(!LegalOperations || TLI.isOperationLegal(ISD::SPLAT_VECTOR, VT))) {
- SDLoc DL(N);
EVT SVT = VT.getScalarType();
return DAG.getSplatVector(
VT, DL, DAG.getNode(ISD::TRUNCATE, DL, SVT, N0->getOperand(0)));
@@ -14779,7 +14774,7 @@ SDValue DAGCombiner::visitTRUNCATE(SDNode *N) {
for (unsigned i = 0, e = BuildVecNumElts; i != e; i += TruncEltOffset)
Opnds.push_back(BuildVect.getOperand(i));
- return DAG.getBuildVector(VT, SDLoc(N), Opnds);
+ return DAG.getBuildVector(VT, DL, Opnds);
}
}
@@ -14842,7 +14837,7 @@ SDValue DAGCombiner::visitTRUNCATE(SDNode *N) {
AddToWorklist(NV.getNode());
Opnds.push_back(NV);
}
- return DAG.getNode(ISD::CONCAT_VECTORS, SDLoc(N), VT, Opnds);
+ return DAG.getNode(ISD::CONCAT_VECTORS, DL, VT, Opnds);
}
}
@@ -14856,11 +14851,9 @@ SDValue DAGCombiner::visitTRUNCATE(SDNode *N) {
if (VecSrcVT.isVector() && VecSrcVT.getScalarType() == VT &&
(!LegalOperations ||
TLI.isOperationLegal(ISD::EXTRACT_VECTOR_ELT, VecSrcVT))) {
- SDLoc SL(N);
-
unsigned Idx = isLE ? 0 : VecSrcVT.getVectorNumElements() - 1;
- return DAG.getNode(ISD::EXTRACT_VECTOR_ELT, SL, VT, VecSrc,
- DAG.getVectorIdxConstant(Idx, SL));
+ return DAG.getNode(ISD::EXTRACT_VECTOR_ELT, DL, VT, VecSrc,
+ DAG.getVectorIdxConstant(Idx, DL));
}
}
@@ -14905,7 +14898,6 @@ SDValue DAGCombiner::visitTRUNCATE(SDNode *N) {
// we are extra cautious to not create an unsupported operation.
// Target-specific changes are likely needed to avoid regressions here.
if (VT.isScalarInteger() || TLI.isOperationLegal(N0.getOpcode(), VT)) {
- SDLoc DL(N);
SDValue NarrowL = DAG.getNode(ISD::TRUNCATE, DL, VT, N0.getOperand(0));
SDValue NarrowR = DAG.getNode(ISD::TRUNCATE, DL, VT, N0.getOperand(1));
return DAG.getNode(N0.getOpcode(), DL, VT, NarrowL, NarrowR);
@@ -14922,7 +14914,6 @@ SDValue DAGCombiner::visitTRUNCATE(SDNode *N) {
if (((!LegalOperations && N0.getOpcode() == ISD::UADDO_CARRY) ||
TLI.isOperationLegal(N0.getOpcode(), VT)) &&
N0.hasOneUse() && !N0->hasAnyUseOfValue(1)) {
- SDLoc DL(N);
SDValue X = DAG.getNode(ISD::TRUNCATE, DL, VT, N0.getOperand(0));
SDValue Y = DAG.getNode(ISD::TRUNCATE, DL, VT, N0.getOperand(1));
SDVTList VTs = DAG.getVTList(VT, N0->getValueType(1));
@@ -14939,7 +14930,7 @@ SDValue DAGCombiner::visitTRUNCATE(SDNode *N) {
VT.getScalarSizeInBits() &&
hasOperation(N0.getOpcode(), VT)) {
return getTruncatedUSUBSAT(VT, SrcVT, N0.getOperand(0), N0.getOperand(1),
- DAG, SDLoc(N));
+ DAG, DL);
}
break;
}
More information about the llvm-commits
mailing list