[llvm] [CSSPGO] Error out if the checksum mismatch is high (PR #84097)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 14 20:01:34 PDT 2024
================
@@ -2184,6 +2204,61 @@ bool SampleProfileLoader::doInitialization(Module &M,
return true;
}
+// Note that this is a module-level check. Even if one module is errored out,
+// the entire build will be errored out. However, the user could make big
+// changes to functions in single module but those changes might not be
+// performance significant to the whole binary. Therefore, we use a conservative
+// approach to make sure we only error out if it globally impacts the binary
+// performance. To achieve this, we use heuristics to select a reasonable
+// big set of functions that are supposed to be globally performance
+// significant, only compute and check the mismatch within those functions. The
+// function selection is based on two criteria: 1) The function is "hot" enough,
+// which is tuned by a hotness-based flag(ChecksumMismatchFuncHotBlockSkip). 2)
+// The num of function is large enough which is tuned by the
+// ChecksumMismatchNumFuncSkip flag.
+bool SampleProfileLoader::errorIfHighChecksumMismatch(
----------------
WenleiHe wrote:
naming nit: `rejectHighStalenessProfile` ?
https://github.com/llvm/llvm-project/pull/84097
More information about the llvm-commits
mailing list