[llvm] [llvm-ar][Object][COFF] Compute UseECMap in computeMemberData. (PR #85230)

Eli Friedman via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 14 13:53:52 PDT 2024


================
@@ -678,6 +678,25 @@ static bool isECObject(object::SymbolicFile &Obj) {
   return false;
 }
 
+static bool useECMap(object::SymbolicFile &Obj) {
+  if (Obj.isCOFF())
+    return COFF::isAnyArm64(cast<COFFObjectFile>(&Obj)->getMachine());
----------------
efriedma-quic wrote:

If I'm following correctly, this unconditionally emits an EC map for arm64 targets, even if there aren't any non-native object files?  But that isn't consistent with the tests, so I think I must be missing something.

https://github.com/llvm/llvm-project/pull/85230


More information about the llvm-commits mailing list