[llvm] [TableGen] fix tlbgen for EncodingByHwMode (PR #84906)

Jason Eckhardt via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 14 13:01:24 PDT 2024


nvjle wrote:

> @nvjle @topperc Hello, could you please help me review my code.

@superZWT123 Please give me a day or two to review this code. From a very quick scan, it actually undoes some of the work I did recently (or at least does it differently)-- which may be fine-- but I need to examine carefully. I'm using this feature in a downstream production backend with a complicated ISA (generously speaking) and even more complicated encoding schemes (100+ decoder tables). It tends to exercise the encode/decode heavily.

Also, my previous patch to suppress duplicates had a command line option so that existing downstream backends could opt-in to that feature-- at least temporarily. That is, a downstream backend could rebase and their disassembler would not need any changes due to decoder table naming. Something like that would probably be good to keep initially.

All of that said, I am certainly glad to see others helping to production-harden this feature.

https://github.com/llvm/llvm-project/pull/84906


More information about the llvm-commits mailing list