[llvm] [llvm-ar][Object][COFF] Compute UseECMap in computeMemberData. (PR #85230)
Daniel Paoliello via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 14 09:36:46 PDT 2024
================
@@ -795,23 +814,36 @@ computeMemberData(raw_ostream &StringTable, raw_ostream &SymNames,
Entry.second = Entry.second > 1 ? 1 : 0;
}
+ std::vector<std::unique_ptr<SymbolicFile>> SymFiles;
+
+ if (NeedSymbols != SymtabWritingMode::NoSymtab || isAIXBigArchive(Kind)) {
+ for (const NewArchiveMember &M : NewMembers) {
+ Expected<std::unique_ptr<SymbolicFile>> SymFileOrErr =
+ getSymbolicFile(M.Buf->getMemBufferRef(), Context);
+ if (!SymFileOrErr)
+ return createFileError(M.MemberName, SymFileOrErr.takeError());
+
+ // Use EC map if any member is ARM64 COFF file.
----------------
dpaoliello wrote:
Just a small clarification, since I had to check `isAnyArm64` to verify.
```suggestion
// Use EC map if any member is ARM64 (including EC) COFF file.
```
https://github.com/llvm/llvm-project/pull/85230
More information about the llvm-commits
mailing list