[llvm] [mlir] [mlir] Move InlinerInterface from Transforms to Interfaces. (PR #84878)

Christian Sigg via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 14 00:39:58 PDT 2024


chsigg wrote:

> No: they are really header-only dependency, you don't need the link target.
> You need to link to register the interface implementation only IIRC.

Right, but dialect registration is part of the dialect target as well, and depending on just the header would make it not self-contained. Of course, most binary targets that depend on a few dialects will also depend on TransformUtils somehow. It does work the way it's set up right now, but the layering is not ideal and breaks e.g. managing dependencies automatically by tools.

https://github.com/llvm/llvm-project/pull/84878


More information about the llvm-commits mailing list