[llvm] AMDGPU: Discussion: Do we actually need these TSFlags bits in Real? (PR #85132)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 13 23:54:55 PDT 2024


arsenm wrote:

> If we always use something like TSFlags & SIInstrFlags::VM_CNT to reference individual bit, then we do not need to care about individual bits in Real at all.

We don't really have proper enums in tablegen, and it's not pretty to do a bitextract. TSFlags is really an implementation detail to populate the MCInstrDesc field, I don't think we really want to have to rely on using it inside tablegen and the named values are nicer 

https://github.com/llvm/llvm-project/pull/85132


More information about the llvm-commits mailing list