[compiler-rt] [hwasan] Fix DCHECK with COMPILER_RT_DEBUG=ON (PR #84612)

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 13 13:53:15 PDT 2024


================
@@ -140,7 +140,7 @@ __attribute__((always_inline, nodebug)) static inline uptr ShortTagSize(
 
 __attribute__((always_inline, nodebug)) static inline bool
 PossiblyShortTagMatches(tag_t mem_tag, uptr ptr, uptr sz) {
-  DCHECK(IsAligned(ptr, kShadowAlignment));
+  DCHECK(IsAligned(ptr, sz));
----------------
vitalybuka wrote:

This change conflicts with CheckAddressSized @ line 186, where tail_sz can be anything

However can I see how this DCHECK fails for CheckAddress.

PossiblyShortTagMatches @ line 
```
return *(u8 *)(ptr | (kShadowAlignment - 1)) == ptr_tag;
```
expects that ptr points to the first bite of the granule.


https://github.com/llvm/llvm-project/pull/84612


More information about the llvm-commits mailing list