[llvm] 628a79d - [InstCombine] Don't generate crash dialog for fixpoint verification failure (NFC)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 13 08:11:20 PDT 2024


Author: Nikita Popov
Date: 2024-03-13T16:11:11+01:00
New Revision: 628a79dad30befed82ee1c115b00fa9aca5305ed

URL: https://github.com/llvm/llvm-project/commit/628a79dad30befed82ee1c115b00fa9aca5305ed
DIFF: https://github.com/llvm/llvm-project/commit/628a79dad30befed82ee1c115b00fa9aca5305ed.diff

LOG: [InstCombine] Don't generate crash dialog for fixpoint verification failure (NFC)

Fixpoint verification failures outside our tests are usually not
indicative of a bug -- don't be pushy about having people report them.

Added: 
    

Modified: 
    llvm/lib/Transforms/InstCombine/InstructionCombining.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp b/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
index 1688005de2104d..c9bbe437b368b3 100644
--- a/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
@@ -5202,7 +5202,8 @@ static bool combineInstructionsOverFunction(
     if (Iteration > Opts.MaxIterations) {
       report_fatal_error(
           "Instruction Combining did not reach a fixpoint after " +
-          Twine(Opts.MaxIterations) + " iterations");
+              Twine(Opts.MaxIterations) + " iterations",
+          /*GenCrashDiag=*/false);
     }
   }
 


        


More information about the llvm-commits mailing list