[llvm] [Orc] Move SymbolStringPool from EPC to ExecutionSession (NFC) (PR #85056)

Stefan Gränitz via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 13 03:41:27 PDT 2024


================
@@ -1453,7 +1453,8 @@ class ExecutionSession {
 
   /// Construct an ExecutionSession with the given ExecutorProcessControl
   /// object.
-  ExecutionSession(std::unique_ptr<ExecutorProcessControl> EPC);
+  ExecutionSession(std::unique_ptr<ExecutorProcessControl> EPC,
+                   std::shared_ptr<SymbolStringPool> SSP = nullptr);
----------------
weliveindetail wrote:

If we keep the default value here, we don't need the second patch. It would reduce the PR size significantly: https://github.com/llvm/llvm-project/pull/85056/commits/23a9ec6ce3fa87e0cdaabab420d9f9938f246d0d

I am not sure though, do we want default values in the public headers?

https://github.com/llvm/llvm-project/pull/85056


More information about the llvm-commits mailing list