[compiler-rt] [sanitizer][windows] report symbols in clang_rt. or \compiler-rt\lib\ as internal. (PR #84971)

Charlie Barto via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 12 17:44:44 PDT 2024


================
@@ -39,8 +39,12 @@ static bool FrameIsInternal(const SymbolizedStack *frame) {
                internal_strstr(file, "/include/c++/") ||
                internal_strstr(file, "/include/g++")))
     return true;
+  if (file && internal_strstr(file, "\\compiler-rt\\lib\\"))
+    return true;
   if (module && (internal_strstr(module, "libclang_rt.")))
     return true;
+  if (module && (internal_strstr(module, "clang_rt.")))
----------------
barcharcraz wrote:

I mean not if you happened to build the library with that name....

It might show up for cygwin or mingw builds. I don't see a reason to do platform specific preprocessing here.

https://github.com/llvm/llvm-project/pull/84971


More information about the llvm-commits mailing list