[llvm] [ArgPromotion] Remove incorrect TranspBlocks set for loads. (PR #84835)

[Florian Hahn via llvm-commits]

fhahn wrote:

> I don't think this code is particularly hot, but it would probably make sense to move it to use BatchAA at least.

Sounds good, we would need to add the functions used by ArgumentPromotion to BatchAA.

> Maybe it's worth looking into fixing the API of inverse_depth_first_ext/etc. to be less error-prone? For example, maybe we can make it automatically clear the storage when it's constructed, or something like that.

I am not sure, I had a look at the other sues of `inverse_depth_first_ext` and they all seem to intentionally use it to extend the visited set across multiple invocations of `inverse_depth_first_ext`. If a fresh set should be used on each invocation, `inverse_depth_first` can be used instead. Put up #84920 to update the single instance I think is applicable. 


https://github.com/llvm/llvm-project/pull/84835