[llvm] [llvm-debuginfo-analyzer] Add support for WebAssembly binary format. (PR #82588)
Carlos Alberto Enciso via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 12 05:38:54 PDT 2024
CarlosAlbertoEnciso wrote:
> Does this mean this whole file will be renamed, or only the wasm-related parts will be spun off as a new file?
The plans are to prepare a separate NFC patch with the following changes:
Filename change: `LVElfReader.cpp[h]` -> `LVDWARFReader.cpp[h]`
Class name change: `LVELFReader` -> `LVDWARFReader`
The names will reflect the Debug Information format being processed (DWARF) and not the binary format (ELF, MachO and Wasm).
> The comment looks like the whole file/class will be renamed.. Then does this class not support ELF anymore?
It will support ELF.
> The file heading says it supports ELF/MachO. (Should we update that too?)
For the time being, we can change the file heading to say something like:
```
// This implements the LVELFReader class.
// It supports ELF, Mach-O and Wasm binary formats.
```
https://github.com/llvm/llvm-project/pull/82588
More information about the llvm-commits
mailing list