[llvm] Run pre-merge build with -k 0 placed after "${BUILD_DIR}" (PR #84846)

Connor Sughrue via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 11 15:38:55 PDT 2024


https://github.com/cpsughrue created https://github.com/llvm/llvm-project/pull/84846

#84828 added `-k 0` to pre-merge CI so that if one job fails the others would continue building. This pull request fixes the location of `-k 0` in the ninja command line.

Resolves #84842 and #83371

>From 59a5ba0624bb3daef46a6adfca2a209dd7203837 Mon Sep 17 00:00:00 2001
From: cpsughrue <cpsughrue at gmail.com>
Date: Mon, 11 Mar 2024 18:32:14 -0400
Subject: [PATCH] Correct pre-commit CI ninja invocation

---
 .ci/monolithic-linux.sh   | 2 +-
 .ci/monolithic-windows.sh | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/.ci/monolithic-linux.sh b/.ci/monolithic-linux.sh
index fe1a9e57ff4aa7..9e670c447fbadd 100755
--- a/.ci/monolithic-linux.sh
+++ b/.ci/monolithic-linux.sh
@@ -54,4 +54,4 @@ cmake -S ${MONOREPO_ROOT}/llvm -B ${BUILD_DIR} \
 
 echo "--- ninja"
 # Targets are not escaped as they are passed as separate arguments.
-ninja -C -k 0 "${BUILD_DIR}" ${targets}
+ninja -C "${BUILD_DIR}" -k 0 ${targets}
diff --git a/.ci/monolithic-windows.sh b/.ci/monolithic-windows.sh
index c12e5544c1a184..52ba13036f9159 100755
--- a/.ci/monolithic-windows.sh
+++ b/.ci/monolithic-windows.sh
@@ -62,4 +62,4 @@ cmake -S ${MONOREPO_ROOT}/llvm -B ${BUILD_DIR} \
 
 echo "--- ninja"
 # Targets are not escaped as they are passed as separate arguments.
-ninja -C -k 0 "${BUILD_DIR}" ${targets}
+ninja -C "${BUILD_DIR}" -k 0 ${targets}



More information about the llvm-commits mailing list