[llvm] Run pre-merge build with -k 0 to ensure all tests runs (PR #84828)

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 11 13:45:25 PDT 2024


https://github.com/joker-eph created https://github.com/llvm/llvm-project/pull/84828

The -k option allows to continue the build after failures as much as possible. This is useful here because when we run

> ninja check-llvm check-clang

we would like the clang tests to run even if there is a failure in a llvm tests.

Fixes #83371

>From b727da6c0f7ce983a9422a692f73c3180f404bf5 Mon Sep 17 00:00:00 2001
From: Mehdi Amini <joker.eph at gmail.com>
Date: Mon, 11 Mar 2024 13:42:55 -0700
Subject: [PATCH] Run pre-merge build with -k 0 to ensure all tests runs

The -k option allows to continue the build after failures as much
as possible. This is useful here because when we run

> ninja check-llvm check-clang

we would like the clang tests to run even if there is a failure in
a llvm tests.

Fixes #83371
---
 .ci/monolithic-linux.sh   | 2 +-
 .ci/monolithic-windows.sh | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/.ci/monolithic-linux.sh b/.ci/monolithic-linux.sh
index 1e7b2d2a36c245..fe1a9e57ff4aa7 100755
--- a/.ci/monolithic-linux.sh
+++ b/.ci/monolithic-linux.sh
@@ -54,4 +54,4 @@ cmake -S ${MONOREPO_ROOT}/llvm -B ${BUILD_DIR} \
 
 echo "--- ninja"
 # Targets are not escaped as they are passed as separate arguments.
-ninja -C "${BUILD_DIR}" ${targets}
+ninja -C -k 0 "${BUILD_DIR}" ${targets}
diff --git a/.ci/monolithic-windows.sh b/.ci/monolithic-windows.sh
index 9561bf668a90cb..c12e5544c1a184 100755
--- a/.ci/monolithic-windows.sh
+++ b/.ci/monolithic-windows.sh
@@ -62,4 +62,4 @@ cmake -S ${MONOREPO_ROOT}/llvm -B ${BUILD_DIR} \
 
 echo "--- ninja"
 # Targets are not escaped as they are passed as separate arguments.
-ninja -C "${BUILD_DIR}" ${targets}
+ninja -C -k 0 "${BUILD_DIR}" ${targets}



More information about the llvm-commits mailing list