[llvm] [RFC] Memory Model Relaxation Annotations (PR #78569)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 11 10:13:22 PDT 2024


================
@@ -132,7 +132,8 @@ struct ReplacementIRBuilder : IRBuilder<InstSimplifyFolder> {
   explicit ReplacementIRBuilder(Instruction *I, const DataLayout &DL)
       : IRBuilder(I->getContext(), DL) {
     SetInsertPoint(I);
-    this->CollectMetadataToCopy(I, {LLVMContext::MD_pcsections});
+    this->CollectMetadataToCopy(
+        I, {LLVMContext::MD_pcsections, LLVMContext::MD_mmra});
----------------
nikic wrote:

I don't think this is an appropriate way to copy mmra metadata. If it's not something that can actually be copied to ~all instructions created by IRBuilder, then it's better to copy it explicitly for the instructions where it makes sense.

https://github.com/llvm/llvm-project/pull/78569


More information about the llvm-commits mailing list