[llvm] [RemoveDIs] Update DIBuilder to conditionally insert DbgRecords (PR #84739)

[Orlando Cazalet-Hyams via llvm-commits]

OCHyams wrote:

>Is it possible that the C-interface changes could be split into a separate patch? My concern is that it's going to be a very disruptive patch, and so the commit that breaks everyone using the llvm-c interface should be as small and specific as possible.

SGTM. We could even consider leaving the C interface in an "old-format-only-mode" until we completely remove the "old format". The only thing that'd need to change in the C API at that point would be the return type of those functions. Looking at usages of DIBuilder in LLVM and Clang, the return type isn't used very often, so applying that update to a codebase using the builder API in a similar fashion would be trivial (there may be no work to do in a lot of cases). wdyt?

https://github.com/llvm/llvm-project/pull/84739