[llvm] Revert "[RemoveDIs] Add additional debug-mode verifier checks" (PR #84757)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 11 06:10:28 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-ir
Author: Orlando Cazalet-Hyams (OCHyams)
<details>
<summary>Changes</summary>
Reverts llvm/llvm-project#<!-- -->84308
Failing bots, e.g. https://lab.llvm.org/buildbot/#/builders/16/builds/62432
---
Full diff: https://github.com/llvm/llvm-project/pull/84757.diff
1 Files Affected:
- (modified) llvm/lib/IR/Verifier.cpp (-10)
``````````diff
diff --git a/llvm/lib/IR/Verifier.cpp b/llvm/lib/IR/Verifier.cpp
index 0e6c01802cfb8c..ce090c3b8a7444 100644
--- a/llvm/lib/IR/Verifier.cpp
+++ b/llvm/lib/IR/Verifier.cpp
@@ -2691,11 +2691,6 @@ void Verifier::visitFunction(const Function &F) {
Check(verifyAttributeCount(Attrs, FT->getNumParams()),
"Attribute after last parameter!", &F);
- CheckDI(F.IsNewDbgInfoFormat == F.getParent()->IsNewDbgInfoFormat,
- "Function debug format should match parent module", &F,
- F.IsNewDbgInfoFormat, F.getParent(),
- F.getParent()->IsNewDbgInfoFormat);
-
bool IsIntrinsic = F.isIntrinsic();
// Check function attributes.
@@ -3039,11 +3034,6 @@ void Verifier::visitBasicBlock(BasicBlock &BB) {
Check(I.getParent() == &BB, "Instruction has bogus parent pointer!");
}
- CheckDI(BB.IsNewDbgInfoFormat == BB.getParent()->IsNewDbgInfoFormat,
- "BB debug format should match parent function", &BB,
- BB.IsNewDbgInfoFormat, BB.getParent(),
- BB.getParent()->IsNewDbgInfoFormat);
-
// Confirm that no issues arise from the debug program.
if (BB.IsNewDbgInfoFormat)
CheckDI(!BB.getTrailingDPValues(), "Basic Block has trailing DbgRecords!",
``````````
</details>
https://github.com/llvm/llvm-project/pull/84757
More information about the llvm-commits
mailing list