[compiler-rt] [asan] Remove XFAIL from tests that are passing with debug checks (PR #84614)

Rainer Orth via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 11 03:16:17 PDT 2024


rorth wrote:

I've now run three pairs of build without and with your patch,  all of them with `-DCMAKE_BUILD_TYPE=Debug  -DCOMPILER_RT_DEBUG=On`, on `amd64-pc-solaris2.11`, `sparcv9-sun-solaris2.11`, and `x86_64-pc-linux-gnu`.

Solaris/amd64 showed the expected difference:
```
--- dist-amd64-debug-stage2/llvm.sum	2024-03-10 15:54:56.672619897 +0100
+++ local-amd64-debug-stage2/llvm.sum	2024-03-10 20:21:46.692694749 +0100
@@ -1,6 +0,0 @@
-Unexpectedly Passed Tests (4):
-  AddressSanitizer-i386-sunos :: TestCases/Posix/start-deactivated.cpp
-  AddressSanitizer-i386-sunos :: TestCases/handle_noreturn_bug.cpp
-  AddressSanitizer-i386-sunos-dynamic :: TestCases/Posix/start-deactivated.cpp
-  AddressSanitizer-i386-sunos-dynamic :: TestCases/handle_noreturn_bug.cpp
-
```
Solaris/sparcv9 is unchanged since asan doesn't work due to a backend bug.  However, Linux/x86_64 shows mixed results:
```
--- dist-x86_64-debug-stage2/llvm.sum	2024-03-10 15:29:46.059902188 +0100
+++ local-x86_64-debug-stage2/llvm.sum	2024-03-10 23:18:06.724520826 +0100
@@ -1 +1 @@
-Failed Tests (310):
+Failed Tests (315):
@@ -5,0 +6 @@
+  AddressSanitizer-x86_64-linux-dynamic :: TestCases/Linux/activation-options.cpp
@@ -37,0 +39,2 @@
+  AddressSanitizer-x86_64-linux-dynamic :: TestCases/Linux/odr-violation.cpp
+  AddressSanitizer-x86_64-linux-dynamic :: TestCases/Linux/odr-vtable.cpp
@@ -122,0 +126 @@
+  AddressSanitizer-x86_64-linux-dynamic :: TestCases/Posix/start-deactivated.cpp
@@ -181,0 +186 @@
+  AddressSanitizer-x86_64-linux-dynamic :: TestCases/handle_noreturn_bug.cpp
@@ -312,17 +316,0 @@
-
-Unexpectedly Passed Tests (15):
-  AddressSanitizer-i386-linux :: TestCases/Linux/activation-options.cpp
-  AddressSanitizer-i386-linux :: TestCases/Linux/odr-violation.cpp
-  AddressSanitizer-i386-linux :: TestCases/Linux/odr-vtable.cpp
-  AddressSanitizer-i386-linux :: TestCases/Posix/start-deactivated.cpp
-  AddressSanitizer-i386-linux :: TestCases/handle_noreturn_bug.cpp
-  AddressSanitizer-i386-linux-dynamic :: TestCases/Linux/activation-options.cpp
-  AddressSanitizer-i386-linux-dynamic :: TestCases/Linux/odr-violation.cpp
-  AddressSanitizer-i386-linux-dynamic :: TestCases/Linux/odr-vtable.cpp
-  AddressSanitizer-i386-linux-dynamic :: TestCases/Posix/start-deactivated.cpp
-  AddressSanitizer-i386-linux-dynamic :: TestCases/handle_noreturn_bug.cpp
-  AddressSanitizer-x86_64-linux :: TestCases/Linux/activation-options.cpp
-  AddressSanitizer-x86_64-linux :: TestCases/Linux/odr-violation.cpp
-  AddressSanitizer-x86_64-linux :: TestCases/Linux/odr-vtable.cpp
-  AddressSanitizer-x86_64-linux :: TestCases/Posix/start-deactivated.cpp
-  AddressSanitizer-x86_64-linux :: TestCases/handle_noreturn_bug.cpp
```
While several `XPASS`es are gone, all affected `AddressSanitizer-x86_64-linux-dynamic` tests now `FAIL`.  Still the same uglyness I already reported in the Issue.

https://github.com/llvm/llvm-project/pull/84614


More information about the llvm-commits mailing list