[llvm] [InstrProf] Change step from 64-bit to pointer-sized int (PR #83239)

Brian Smith via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 9 13:08:31 PST 2024


briansmith wrote:

@jdmitrovic-syrmia I would love to review this but I am not an LLVM project member and I don't understand the implementation well enough to offer useful feedback on the implementation.

For my interests, I am primarily interested in code coverage and not profiling.

I also found https://discourse.llvm.org/t/rfc-single-byte-counters-for-source-based-code-coverage/75685 which addresses the problem in a different way. Note that it is claimed there that "A nice advantage of single-byte counters is that it is already thread-safe without needing atomics." It was just merged a couple of weeks ago; see https://github.com/llvm/llvm-project/pull/75425. 

https://github.com/llvm/llvm-project/pull/83239


More information about the llvm-commits mailing list